Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEIGHT_PROOF_SIZE
in src/config/moonbase-local.jsgetProxyAccount
function for Moonbase.Both Moonbase and Moonbeam have updated their algorithms for computing derived account to
HashedDescriptionDescribeFamilyAllTerminal
. So we should follow the modification.https://github.com/moonbeam-foundation/moonbeam/blob/93548eeba1e32361c401c58c87596b400707557a/runtime/moonbase/src/xcm_config.rs#L114
The implementation details are available here:
https://github.com/moonbeam-foundation/polkadot/blob/89fd916a027ea7fb4a1b0092d0259e7897b45a79/xcm/xcm-builder/src/location_conversion.rs#L40
Our implementation refers to:
https://github.com/Moonsong-Labs/xcm-tools/blob/d7618f219e7ceecd4b4c34ad686b25621b5eabff/scripts/calculate-multilocation-derivative-account.ts#L38
Log: