Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Moonbase collator balance #766

Merged

Conversation

imstar15
Copy link
Contributor

@imstar15 imstar15 commented Mar 2, 2023

Fix the error that occurs when Moonbase starts:

Thread 'main' panicked at 'Account does not have enough balance to bond as a candidate.

@pepoviola
Copy link
Collaborator

Hi @imstar15, looks good. Can you lint the code with

npm run lint:write

and push the changes.

Thanks!!

@imstar15
Copy link
Contributor Author

imstar15 commented Mar 3, 2023

Hi @pepoviola
continuous-integration/gitlab-paras failed. How should I fix it?

@chrisli30
Copy link

chrisli30 commented Mar 8, 2023

Hi @wirednkod, this is Chris Li from OAK Network. There are three tasks failed from the check automation of this PR, but we don’t have permission to view those.

continuous-integration/gitlab-paras — {"build_allow_failure":true}
continuous-integration/gitlab-publish-docker-pr — {"build_allow_failure":false}
continuous-integration/gitlab-publish-test — {"build_allow_failure":false}

How could we help resolve those issues?

@pepoviola
Copy link
Collaborator

Hi @wirednkod, this is Chris Li from OAK Network. There are three tasks failed from the check automation of this PR, but we don’t have permission to view those.

continuous-integration/gitlab-paras — {"build_allow_failure":true} continuous-integration/gitlab-publish-docker-pr — {"build_allow_failure":false} continuous-integration/gitlab-publish-test — {"build_allow_failure":false}

How could we help resolve those issues?

Hi @chrisli30, I'm re-running our pipeline now.
Thanks!!

@pepoviola
Copy link
Collaborator

ci is failing with this error now

Thread 'main' panicked at 'duplicate balances in genesis.', /home/gh-actions/.cargo/git/checkouts/substrate-189071a041b0d328/c674000/frame/balances/src/lib.rs:588

I will check it locally.

@chrisli30
Copy link

Great, thanks for the help Javier!

@pepoviola
Copy link
Collaborator

Hi @chrisli30, can you update your branch merging master. I think the dup issue should be fixed now.
Thanks!

@pepoviola pepoviola added the question Further information is requested label Jul 7, 2023
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Aug 6, 2023

User @chrisli30, please sign the CLA here.

@pepoviola pepoviola merged commit 23d4055 into paritytech:main Aug 6, 2023
1 check passed
@chrisli30
Copy link

chrisli30 commented Aug 6, 2023

@pepoviola Thank you for facilitating this PR!

I have rerun the latest code of zombienet and comfirm that this PR fixes the below error with Moonbeam runtime-2403
Thread 'main' panicked at 'Account does not have enough balance to bond as a candidate.', /moonbeam/pallets/parachain-staking/src/lib.rs:684

@chrisli30 chrisli30 deleted the fix-moonbase-collator-balance branch August 6, 2023 20:00
@pepoviola
Copy link
Collaborator

Awesome! Thanks for your feedback and contribution 🙌.
I will draft a new release tomorrow.
Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants