NTLMv2 with MAC and EPA support #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dlorych
changed the title
|
@paulmey I'm trying to delete the contents of this PR - wrong author. Could you help me out with it? |
NTLMv2 `authenticate` messages are expected to include MIC field. MIC is a hash of 3 concatenated exchanged messages (`negotiate`, `challenge` and `authenticate`) As a MIC field is part of the `authenticate` message, during a calculation the field is expected to be filled out with zeroes. Once calculated the value is back-filled inside the `authenticate` byte array.
NTLMv2 is expected to fill out information about the remote server in a form of SPN value in a AvTargetName AvPair field. Extracted `getTimestamp` function and added a comment on the structure of the timestamp byte array.
Add AvPairs type to handle (un-)marshalling Extract logic of updating target info values to separate funtion Add SPN target info field - necessary with for Extended Protection for Authentication (WIP - to fully support Channel Binding Token is necessary).
EPA Extended Security for Authentication is based on adding channel binding token (CBT) to `authenticate` message (TargetInfo AvPair structure)
- Move defaultFlags to negotiation_flags.go file - Change `defaultFlags` to follow [MS-NLMP] documentation - Modify "negotiation", so it is composed of shared part, with exception of EXTENDED_SESSIONSECURITY, which shall be enabled always
dlorych
force-pushed
the
add-ntlmv2-support
branch
from
e07facf
to
022e948
Compare
dlorych
changed the title
|
@paulmey I managed to solve the authorship issues. Feel free to review PR and suggest changes. |
|
Hi, I have used that version from @dlorych and it works well for me in adcs-issuer (for cert-manager) with NTLMv2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NTLMv2 with MAC and channel binding support
I had trouble using library in my environment, but finally managed to solve it by refactoring code to follow NTLMv2 standard according to
NTLM protocol description, in particular:
Connection against secured IIS (NTLMv2 and enabled EPA) is working in my environment, but there's a hight risk that it can break in a different environment, especially ones that do no support NTLMv2 fully.
Could anyone assess the changes and test in their environment?