-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTLMv2 with MAC and EPA support #35
Open
dlorych
wants to merge
8
commits into
Azure:master
Choose a base branch
from
dlorych:add-ntlmv2-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 20, 2022
-
NTLMv2 `authenticate` messages are expected to include MIC field. MIC is a hash of 3 concatenated exchanged messages (`negotiate`, `challenge` and `authenticate`) As a MIC field is part of the `authenticate` message, during a calculation the field is expected to be filled out with zeroes. Once calculated the value is back-filled inside the `authenticate` byte array.
Configuration menu - View commit details
-
Copy full SHA for 777be83 - Browse repository at this point
Copy the full SHA 777be83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f1b910 - Browse repository at this point
Copy the full SHA 3f1b910View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1031e7e - Browse repository at this point
Copy the full SHA 1031e7eView commit details -
Add AvTargetName with SPN of the web server
NTLMv2 is expected to fill out information about the remote server in a form of SPN value in a AvTargetName AvPair field. Extracted `getTimestamp` function and added a comment on the structure of the timestamp byte array.
Configuration menu - View commit details
-
Copy full SHA for a744b1b - Browse repository at this point
Copy the full SHA a744b1bView commit details -
Refactor target info values handling
Add AvPairs type to handle (un-)marshalling Extract logic of updating target info values to separate funtion Add SPN target info field - necessary with for Extended Protection for Authentication (WIP - to fully support Channel Binding Token is necessary).
Configuration menu - View commit details
-
Copy full SHA for 9109407 - Browse repository at this point
Copy the full SHA 9109407View commit details -
Add support for Extended Security for Auth
EPA Extended Security for Authentication is based on adding channel binding token (CBT) to `authenticate` message (TargetInfo AvPair structure)
Configuration menu - View commit details
-
Copy full SHA for c475236 - Browse repository at this point
Copy the full SHA c475236View commit details -
Configuration menu - View commit details
-
Copy full SHA for da7cc28 - Browse repository at this point
Copy the full SHA da7cc28View commit details -
- Move defaultFlags to negotiation_flags.go file - Change `defaultFlags` to follow [MS-NLMP] documentation - Modify "negotiation", so it is composed of shared part, with exception of EXTENDED_SESSIONSECURITY, which shall be enabled always
Configuration menu - View commit details
-
Copy full SHA for 022e948 - Browse repository at this point
Copy the full SHA 022e948View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.