⭐ Pass login info from front to back (#139)

* ⭐ Pass login info from front to back

* 'loginInfo' no longer needs to be a global variable; it is passed from
from top-level to all functions that require it

* Temporarily remove code of updating & deleting labels/milestones

* Numerous minor updates

src/core/apiCalls/apiResponseGetter.js

@@ -6,5 +6,6 @@ import {
 export const getApiResponseOfListing = (loginInfo, entryType, action) =>
   getResponseOfHttpGETFromPaginatedApi(loginInfo, entryType, action);
 
-export const getApiResponseOfCreating = (loginInfo, entryType, body) =>
-  getResponseOfHttpPOST(loginInfo, entryType, body);
+export const getApiResponseOfCreating = (loginInfo, entryType, entry) => {
+  return getResponseOfHttpPOST(loginInfo, entryType, entry);
+};

src/core/apiCalls/httpRequests/HttpError.js

@@ -1,6 +1,7 @@
 export default class HttpError extends Error {
   constructor(response = {}) {
     let message = 'HTTP request failed';
+
     const responseStatus = response.status;
 
     if (responseStatus) {

src/core/apiCalls/httpRequests/httpRequestBodyBuilder.js

@@ -1,27 +1,76 @@
-export const buildHttpRequestBodyForLabels = () => {
+export const buildHttpRequestBodyForLabelToBeCreatedOnGithub = (label) => {
+  const { name, description, color } = label;
+  const colorWithoutLeadingHex = color.substring(1);
+
   const body = {
-    name: 'type: feature request',
-    color: '001122',
-    description: 'Suggestion to new features',
+    name,
+    description,
+    color: colorWithoutLeadingHex,
   };
+
   return body;
 };
 
-export const buildHttpRequestBodyForMilestones = () => {
+export const buildHttpRequestBodyForLabel = (loginInfo, label) => {
+  const { domain } = loginInfo;
+  const { action } = label;
+
+  const funcToBuildHttpRequestBodyForLabelToBe = {
+    github: {
+      create: (_label) => buildHttpRequestBodyForLabelToBeCreatedOnGithub(_label),
+    },
+  };
+
+  const buildHttpRequestBodyForLabelToBe =
+    funcToBuildHttpRequestBodyForLabelToBe[domain][action];
+
+  const body = buildHttpRequestBodyForLabelToBe(label);
+  return body;
+};
+
+export const buildHttpRequestBodyForMilestoneToBeCreatedOnGithub = (milestone) => {
+  const { title, state, description, dueOn } = milestone;
+
   const body = {
-    title: 'Backlog',
-    state: 'open',
-    description: 'Work not yet planned for a specific release',
-    due_on: '2030-04-01T09:00:00Z',
+    title,
+    state,
+    description,
+    due_on: dueOn,
+  };
+
+  return body;
+};
+
+export const buildHttpRequestBodyForMilestone = (loginInfo, milestone) => {
+  const { domain } = loginInfo;
+  const { action } = milestone;
+
+  const funcToBuildHttpRequestBodyForMilestoneToBe = {
+    github: {
+      create: (_milestone) =>
+        buildHttpRequestBodyForMilestoneToBeCreatedOnGithub(_milestone),
+    },
   };
+
+  const buildHttpRequestBodyForMilestoneToBe =
+    funcToBuildHttpRequestBodyForMilestoneToBe[domain][action];
+
+  const body = buildHttpRequestBodyForMilestoneToBe(milestone);
   return body;
 };
 
-export const buildHttpRequestBody = (entryType) => {
-  const httpRequestBodyBuilders = {
-    labels: buildHttpRequestBodyForLabels(),
-    milestones: buildHttpRequestBodyForMilestones(),
+export const buildHttpRequestBody = (loginInfo, entryType, entry) => {
+  const funcToBuildHttpRequestBodyForEntryType = {
+    labels: (_loginInfo, label) => buildHttpRequestBodyForLabel(_loginInfo, label),
+    milestones: (_loginInfo, milestone) =>
+      buildHttpRequestBodyForMilestone(_loginInfo, milestone),
   };
-  const body = httpRequestBodyBuilders[entryType];
-  return JSON.stringify(body);
+
+  const buildHttpRequestBodyForEntryType =
+    funcToBuildHttpRequestBodyForEntryType[entryType];
+
+  const body = buildHttpRequestBodyForEntryType(loginInfo, entry);
+
+  // Note: the returned body is not stringified
+  return body;
 };

src/core/apiCalls/httpRequests/httpRequestHeaderBuilder.js

@@ -10,5 +10,6 @@ export const buildHttpRequestHeader = (loginInfo) => {
     Accept: buildAcceptHeaderForHttpRequest(),
     Authorization: buildAuthorizationHeaderForHttpRequest(loginInfo),
   };
+
   return headers;
 };

src/core/apiCalls/httpRequests/httpRequestMaker.js

@@ -1,11 +1,9 @@
 import { buildHttpRequestHeader } from './httpRequestHeaderBuilder';
 
-export const obtainHttpMethodsThatDoNotHaveBody = () => new Set().add('GET');
-
 export const returnTrueIfNoNeedToAddHttpRequestBody = (method) => {
+  const obtainHttpMethodsThatDoNotHaveBody = () => new Set().add('GET').add('DELETE');
   const httpMethodsThatDoNotHaveBody = obtainHttpMethodsThatDoNotHaveBody();
   const noNeedToAddBody = httpMethodsThatDoNotHaveBody.has(method);
-
   return noNeedToAddBody;
 };
 
@@ -17,7 +15,9 @@ export const buildOptionsForFetchApi = (loginInfo, method, body = {}) => {
 
   const noNeedToAddBody = returnTrueIfNoNeedToAddHttpRequestBody(method);
 
-  if (noNeedToAddBody) return optionsWithoutBody;
+  if (noNeedToAddBody) {
+    return optionsWithoutBody;
+  }
 
   const optionsWithBody = {
     ...optionsWithoutBody,

src/core/apiCalls/httpRequests/httpRequestResponseGetter.js

@@ -1,4 +1,5 @@
 import HttpError from './HttpError';
+import { buildHttpRequestBody } from './httpRequestBodyBuilder';
 import { makeHttpRequest } from './httpRequestMaker';
 import {
   buildUriForHttpRequestGET,
@@ -9,13 +10,18 @@ import { parseLinkHeaderFromHttpResponse } from './linkHeaderParser';
 export const getResponseOfHttpRequest = async (loginInfo, method, uri, body = {}) => {
   const response = await makeHttpRequest(loginInfo, method, uri, body);
   const httpRequestFailed = !response.ok;
-  if (httpRequestFailed) throw new HttpError(response);
+
+  if (httpRequestFailed) {
+    throw new HttpError(response);
+  }
+
   return response;
 };
 
 export const getResponseOfHttpGET = async (loginInfo, entryType, action, uri) => {
   const uriForHttpRequest =
     uri || buildUriForHttpRequestGET(loginInfo, entryType, action);
+
   const response = await getResponseOfHttpRequest(loginInfo, 'GET', uriForHttpRequest);
   return response;
 };
@@ -43,7 +49,9 @@ export const getResponseOfHttpGETFromPaginatedApi = async (
     uriOfNextPage,
   } = await parseResponseOfHttpGETFromPaginatedApi(response);
 
-  if (thereIsNoNextPage) return responseBody;
+  if (thereIsNoNextPage) {
+    return responseBody;
+  }
 
   const combineResponseBodyWithNextPage = async () => [
     ...responseBody,
@@ -59,8 +67,9 @@ export const getResponseOfHttpGETFromPaginatedApi = async (
   return responseBodyCombinedWithNextPage;
 };
 
-export const getResponseOfHttpPOST = async (loginInfo, entryType, body) => {
+export const getResponseOfHttpPOST = async (loginInfo, entryType, entry) => {
   const uri = buildUriForHttpRequestPOST(loginInfo, entryType);
+  const body = buildHttpRequestBody(loginInfo, entryType, entry);
   const response = await getResponseOfHttpRequest(loginInfo, 'POST', uri, body);
   const responseBody = await response.json();
   return responseBody;

src/core/apiCalls/httpRequests/httpRequestUriBuilder.js

@@ -5,6 +5,7 @@ export const getUriBuilderOfListing = (entryType) => {
     labels: (uri) => uri,
     milestones: (uri) => `${uri}&state=all`,
   };
+
   return uriBuilders[entryType];
 };
 
@@ -13,6 +14,7 @@ export const buildUriToList = (uri, entryType) => {
     const apiPaginationLimit = 100;
     return `${uri1}?per_page=${apiPaginationLimit}&page=1`;
   };
+
   const uriWithParams = appendPaginationToUri(uri);
   const buildUri = getUriBuilderOfListing(entryType);
   return buildUri(uriWithParams);
@@ -21,12 +23,13 @@ export const buildUriToList = (uri, entryType) => {
 export const buildUriToCreate = (uri) => uri;
 
 export const getUriBuilderOfAction = (action) => {
-  const uriBuilderFunctions = {
+  const funcToBuildUri = {
     list: (uri, entryType) => buildUriToList(uri, entryType),
     copy: (uri, entryType) => buildUriToList(uri, entryType),
     create: (uri) => buildUriToCreate(uri),
   };
-  const buildFunc = uriBuilderFunctions[action];
+
+  const buildFunc = funcToBuildUri[action];
   return buildFunc;
 };
 

src/core/apiCalls/httpRequests/linkHeaderParser.js

@@ -35,6 +35,5 @@ export const parseLinkHeaderFromHttpResponse = (response) => {
   const { headers } = response;
   const rawLinkHeader = headers.get('link');
   const parsedLinkHeader = parseLinkHeader(rawLinkHeader);
-
   return parsedLinkHeader;
 };

src/core/communicationsWithApi.js

@@ -8,6 +8,14 @@ export const makeApiCallToCopy = async (loginInfo, entryType) => {
   return getApiResponseOfListing(loginInfo, entryType, 'copy');
 };
 
-export const makeApiCallToCreate = async (loginInfo, entryType, body) => {
-  return getApiResponseOfCreating(loginInfo, entryType, body);
+export const makeApiCallToCreate = async (loginInfo, entryType, entry) => {
+  return getApiResponseOfCreating(loginInfo, entryType, entry);
 };
+
+// export const commitChangesByMakingApiCalls = (inputFromFrontEnd) => {
+// const { loginInfo, labels, milestones } = inputFromFrontEnd;
+
+// // parse labels for next step
+// const processedLabelsForApiCalls = processLabelsForApiCalls(loginInfo, labels);
+// const processedMilestonesForApiCalls = processMilestonesForApiCalls(loginInfo, labels);
+// };

src/core/defaultEntries/generateUniqueId.js

@@ -1,7 +1,8 @@
 const generateUniqueId = () => {
   const datetimeStr = Date.now().toString(36);
-  const randomStr = Math.random().toString(36).substring(2);
-  const id = `n-${datetimeStr}-${randomStr}`;
+  const randomStr0 = Math.random().toString(36).substring(2, 12);
+  const randomStr1 = Math.random().toString(36).substring(2, 12);
+  const id = `n-${datetimeStr}-${randomStr0}-${randomStr1}`;
   return id;
 };
 

src/core/loginInfo.js

@@ -9,6 +9,7 @@ export const getKeyToLoginInfo = (repoOwnerOrRepoName, homeRepoOrTemplateRepo) =
       name: 'templateRepoName',
     },
   };
+
   return keys[homeRepoOrTemplateRepo][repoOwnerOrRepoName];
 };
 
@@ -22,17 +23,9 @@ export const getRepoInfoFromLoginInfo = (
 };
 
 export const getRepoOwnerAndRepoName = (loginInfo, action) => {
-  let homeRepoOrTemplateRepo;
-  const actionIsToCopyEntriesFromAntemplateRepo = action === 'copy';
-
-  if (actionIsToCopyEntriesFromAntemplateRepo) {
-    homeRepoOrTemplateRepo = 'other';
-  } else {
-    homeRepoOrTemplateRepo = 'home';
-  }
-
+  const actionIsToCopyEntriesFromTemplateRepo = action === 'copy';
+  const homeRepoOrTemplateRepo = actionIsToCopyEntriesFromTemplateRepo ? 'other' : 'home';
   const repoOwner = getRepoInfoFromLoginInfo(loginInfo, 'owner', homeRepoOrTemplateRepo);
   const repoName = getRepoInfoFromLoginInfo(loginInfo, 'name', homeRepoOrTemplateRepo);
-
   return { repoOwner, repoName };
 };

src/core/validations/validationMethods/validateOrThrow.js

@@ -1,7 +1,11 @@
 const validateOrThrow = (item, getValidItems, ErrorClass) => {
   const validItems = getValidItems();
   const givenItemIsInvalid = !validItems.has(item);
-  if (givenItemIsInvalid) throw new ErrorClass(item);
+
+  if (givenItemIsInvalid) {
+    throw new ErrorClass(item);
+  }
+
   return true;
 };
 

src/core/validations/validationOfAction.js

@@ -5,6 +5,5 @@ export const getValidActions = () => new Set(['list', 'copy', 'create', 'update'
 
 export const validateActionOrThrow = (action) => {
   const isValid = validateOrThrow(action, getValidActions, InvalidActionError);
-
   return isValid;
 };

src/core/validations/validationOfEntryType.js

@@ -5,6 +5,5 @@ export const getValidEntryTypes = () => new Set(['labels', 'milestones']);
 
 export const validateEntryTypeOrThrow = (entryType) => {
   const isValid = validateOrThrow(entryType, getValidEntryTypes, InvalidEntryTypeError);
-
   return isValid;
 };

src/test/apiCalls/httpRequests/getApiResponseOfCreating.spec.js

@@ -2,19 +2,22 @@ import { expect } from 'chai';
 
 import { buildAcceptHeaderForHttpRequest } from '../../../core/apiCalls/httpRequests/httpRequestHeaderBuilder';
 import { getApiResponseOfCreating } from '../../../core/apiCalls/apiResponseGetter';
-import { getBaseApiUriSlashRepos } from '../../../core/apiCalls/httpRequests/httpRequestUriBuilder';
 import {
   mockHttpServerSetup,
   mockHttpServerCleanup,
   mockHttpServerForPOSTOnSuccess,
 } from '../../mockHttpServer';
+import { getDummyNewLabel } from '../../dummyData/dummyLabel.setup.test';
+import { getDummyLoginInfo } from '../../dummyData/dummyLoginInfo.setup.test';
 
 describe('Test getApiResponseOfCreating', function () {
-  let uriForHttpPost;
+  let loginInfo;
+  let dummyLabel;
 
   before(function () {
     mockHttpServerSetup();
-    uriForHttpPost = getBaseApiUriSlashRepos();
+    loginInfo = getDummyLoginInfo();
+    dummyLabel = getDummyNewLabel();
   });
 
   after(function () {
@@ -23,13 +26,11 @@ describe('Test getApiResponseOfCreating', function () {
 
   describe('with HTTP responses on success', function () {
     let body;
-    // let response;
 
     describe('the HTTP request sent', function () {
       beforeEach(async function () {
         mockHttpServerForPOSTOnSuccess();
-
-        body = await getApiResponseOfCreating(uriForHttpPost, {});
+        body = await getApiResponseOfCreating(loginInfo, 'labels', dummyLabel);
       });
 
       describe('the HTTP request sent', function () {