Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐ Pass login info from front to back #139

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

dongskyler
Copy link
Member

'loginInfo' no longer needs to be a global variable; it is passed from
from top-level to all functions that require it

'loginInfo' no longer needs to be a global variable; it is passed from
from top-level to all functions that require it
@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #139 (79a8d07) into main (7ae1e7a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        18    +2     
  Lines          177       195   +18     
=========================================
+ Hits           177       195   +18     
Impacted Files Coverage Δ
src/core/apiCalls/httpRequests/HttpError.js 100.00% <ø> (ø)
src/core/apiCalls/httpRequests/linkHeaderParser.js 100.00% <ø> (ø)
src/core/validations/validationOfAction.js 100.00% <ø> (ø)
src/core/validations/validationOfEntryType.js 100.00% <ø> (ø)
src/core/apiCalls/apiResponseGetter.js 100.00% <100.00%> (ø)
...re/apiCalls/httpRequests/httpRequestBodyBuilder.js 100.00% <100.00%> (ø)
.../apiCalls/httpRequests/httpRequestHeaderBuilder.js 100.00% <100.00%> (ø)
src/core/apiCalls/httpRequests/httpRequestMaker.js 100.00% <100.00%> (ø)
...apiCalls/httpRequests/httpRequestResponseGetter.js 100.00% <100.00%> (ø)
...ore/apiCalls/httpRequests/httpRequestUriBuilder.js 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8948338...79a8d07. Read the comment docs.

@dongskyler dongskyler merged commit 29ca259 into main Mar 22, 2021
@dongskyler dongskyler deleted the feature/pass-login-info-from-front-to-back branch March 22, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants