forked from PiRK/ElectrumABC
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobuf generated file outdated #214
Comments
Merged
PiRK
added a commit
that referenced
this issue
May 31, 2022
There are backwards incompatible changes in the latest release of protobuf. See #214 and https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates This is a temporary fix by setting an upper limit to protobuf library. The proper fix would be to regenerate the _pb2.py files, however it is unclear at the moment if this would keep working on systems with `protobuf<4.21`. For reference, ubuntu 22.04 currently has protobuf version 3.12.4.
PiRK
added a commit
to PiRK/ElectrumABC
that referenced
this issue
May 11, 2023
See spesmilo#7922 for a good description of the problem and the rational for restricting to this range of `protobuf` versions. tldr; keepkey support restricts us to `protobuf<4` because we need to support both the new and the old format. This fixes Bitcoin-ABC#214 This removes a lot of DeprecationWarning messages due to outdated pb2 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Protobuf seems to have made a backwards incompatible change in version 3.21 (released on May 26th 2022)
The text was updated successfully, but these errors were encountered: