BIP 70 updates #213
Merged
BIP 70 updates #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are backwards incompatible changes in the latest release of protobuf. See Electron-Cash#214 and https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates This is a temporary fix by setting an upper limit to protobuf library. The proper fix would be to regenerate the _pb2.py files, however it is unclear at the moment if this would keep working on systems with `protobuf<4.21`. For reference, ubuntu 22.04 currently has protobuf version 3.12.4.
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 31, 2022
Summary: Badger Cash and RaiPay use "ecash-" instead of "bitcoincash-" in the headers. I'm also going to apply the same change to Electrum ABC Bitcoin-ABC/ElectrumABC#213 Test Plan: - Generate a payment URI: `curl -L -H 'Content-Type: application/json' -d '{"outputs":[{"address":"1NLcNpAaBBMekgBZk7NxwdxwtSUTfTV8Aq","amount":560}],"currency":"ecash"}' https://pay.badger.cash/create_invoice` - Run `src/qt/bitcoin-qt` - Menu `File` > `Open URI` - Paste the "ecash:?r=<url>" (replace <url> with the url in the reply to the curl command, e.g. https://pay.badger.cash/i/DTKP4) - Send Repeat with the be.cash API: `curl -L -H 'Content-Type: application/json' -d '{"values":{"network":"XEC","outputs":[{"value":3000,"scriptHex":"76a914154205358162a6f59457d83dea828a15261aaba388ac"}]}}' https://p.be.cash/create-invoice` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D11543
|
Note that Bitcoin ABC now also uses these headers: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BIP70 code has not been updated since the fork with Electron Cash.
This fixes some request headers to use "ecash-" instead of "bitcoincash-", to match what is done in https://github.com/badger-cash/cashtab and RaiPay.
Also: