forked from PiRK/ElectrumABC
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename electroncash packages to electrumabc #197
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiRK
changed the title
rename lielectroncash packages to electrumabc
rename electroncash packages to electrumabc
Apr 21, 2022
This will reduce the number of problems for developers and power users installing both electroncash and electrumabc as a library with `pip install .` It opens the way for electrumabc to be used as a library, not just as a packaged application.
PiRK
force-pushed
the
rename_electroncash_electrumabc
branch
2 times, most recently
from
May 10, 2022 10:58
516173d
to
be0da72
Compare
It almost works, but there is a mysterious issue in the MacOS build script:
Very frustrating |
PiRK
force-pushed
the
rename_electroncash_electrumabc
branch
2 times, most recently
from
May 11, 2022 08:07
13ee6ae
to
2a27bf6
Compare
This commit deals with instances not detected by the PyCharm Refactor -> Rename tool.
PiRK
force-pushed
the
rename_electroncash_electrumabc
branch
from
May 11, 2022 09:28
2a27bf6
to
48a13af
Compare
PiRK
added
help wanted
Extra attention is needed
work in progress
Changes are planned for this pull request
labels
May 12, 2022
Status : this needs to be rebased after #257 , or redone from scratch. The blocking item is the Mac OS build which needs to be fixed on Big Sur so I can test it and find out why |
Merged
Done in #260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the number of problems for developers and power users installing both
electroncash
andelectrumabc
as a library withpip install .
It opens the way for
electrumabc
to be used as a library, not just as a packaged application.This was not done earlier because it is an invasive change that can potentially affect the build scripts and various tools in unexpected ways, but it has to be done sooner or later.