Rename packages #260
Merged
Rename packages #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and delete a block of unreachable code Test Plan: ``` python -m electroncash_plugins.fusion.tests python -m electroncash.tests ./electrum-abc ```
Test Plan: ``` ./electrum-abc ``` Open the receive tab, click the QR code, save to file.
Test Plan: run unit tests, run electrum-abc
Test Plan: run electrum-abc, test a few plugins (CashFusion, hw wallets) Build the binaries, test the generated release files
Test Plan: run electrum-abc Build the binaries, test the generated release files
I didn't address the "import electroncash" instances in the previous commit.
|
There is still an issue with the MacOS build. Renaming the package confuses pyinstaller when it comes to copying the tor binary: |
There is a problem with pyinstaller on MacOS if the python lib and the package name are the same (case-insensitive).
Test Plan: run from source, build the release files and test them
Note that there is no such package in the repository, but it is created at runtime when loading an external plugin. TODO: create an external plugin compatible with the new package name to test this (the renaming of the packages is a breaking change for existing external electroncash plugins)
This fixes the case when secp256k1 is already cloned. Other packages are not affected because their git ref is a commit hash.
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the number of problems for developers and power users installing both electroncash and electrumabc as a library with
pip install .It opens the way for electrumabc to be used as a library, not just as a packaged application.
This replaces #197 (rebasing this after all the recent changes, notably #257 , would be harder than redoing the refactoring from scratch)
It also includes cleanups related to touched code: