Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages #260

Merged
merged 12 commits into from
Jan 12, 2023
Merged

Rename packages #260

merged 12 commits into from
Jan 12, 2023

Commits on Jan 11, 2023

  1. use relative imports in electroncash_plugins

    and delete a block of unreachable code
    
    Test Plan:
    
    ```
    python -m electroncash_plugins.fusion.tests
    python -m electroncash.tests
    ./electrum-abc
    ```
    PiRK committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    cd569d7 View commit details
    Browse the repository at this point in the history
  2. use relative imports in electroncash_gui

    Test Plan:
    
    ```
    ./electrum-abc
    ```
    
    Open the receive tab, click the QR code, save to file.
    PiRK committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    5449122 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ffaec3d View commit details
    Browse the repository at this point in the history
  4. fix circular dependency mnemo -> old_mnemonic -> mnemo

    Test Plan:
    run unit tests, run electrum-abc
    PiRK committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    8587f24 View commit details
    Browse the repository at this point in the history
  5. rename electrumabc_plugins package

    Test Plan:
    
    run electrum-abc, test a few plugins (CashFusion, hw wallets)
    
    Build the binaries, test the generated release files
    PiRK committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    aa23df2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4ace021 View commit details
    Browse the repository at this point in the history
  7. rename electrumabc_gui package

    Test Plan:
    
    run electrum-abc
    
    Build the binaries, test the generated release files
    PiRK committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    9f90a5e View commit details
    Browse the repository at this point in the history
  8. use relative imports in electroncash package (follow-up)

    I didn't address the "import electroncash" instances in the previous commit.
    PiRK committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    7f113b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. [build-osx] rename PACKAGE before calling pyinstaller

    There is a problem with pyinstaller on MacOS if the python lib and the package name are the same (case-insensitive).
    PiRK committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    e2f7727 View commit details
    Browse the repository at this point in the history
  2. rename electrumabc package

    Test Plan:
    
    run from source, build the release files and test them
    PiRK committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    afdbe76 View commit details
    Browse the repository at this point in the history
  3. rename electrumabc_external_plugins dynamic package

    Note that there is no such package in the repository, but it is created at runtime when loading an external plugin.
    
    TODO: create an external plugin compatible with the new package name to test this (the renaming of the packages is a breaking change for existing external electroncash plugins)
    PiRK committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    61ea458 View commit details
    Browse the repository at this point in the history
  4. fix build scripts when git refs are defined by their branch name

    This fixes the case when secp256k1 is already cloned. Other packages are not affected because their git ref is a commit hash.
    PiRK committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    edf75f1 View commit details
    Browse the repository at this point in the history