Fix deprecation warnings (protobuf, ssl) #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See spesmilo#7922 for a good description of the problem and the rational for restricting to this range of `protobuf` versions. tldr; keepkey support restricts us to `protobuf<4` because we need to support both the new and the old format. This fixes Bitcoin-ABC#214 This removes a lot of DeprecationWarning messages due to outdated pb2 files.
See: - https://docs.python.org/3/library/ssl.html#ssl.SSLContext.options (deprecated since python 3.7) - https://docs.python.org/3/library/ssl.html#ssl.TLSVersion (replacement)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove a debugging
print