Enable ordered outputs for OP_RETURN use cases (SLP...) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to disable one without necessarily disabling the other.
PiRK
force-pushed
the
order_ouputs_if_op_returnwq
branch
from
9e0e50e
to
325f82b
Compare
Using a namedtuple is an intermediate step before creating a proper class for this. It encapsulate the 3-tuples and makes the code easier to read (attributes rather than indices) backport of spesmilo#4596 and removal of a bunch of code Transaction methods that are unused.
There are use cases that require the op_return to be the first output in a transaction (e.g. SLP), and I'm not aware of any use case that requires it to not be in that position.
The intended use case for this is sending SLP token using a hex encoded op_return payload. Test plan: Check that the new checkbox is only enabled if something is typed into the op_return payload field, and disabled when this payload is deleted. Add multiple outputs in the send tab, leave the op_return field blank. Click "Preview" multiple times and make sure the outputs are shuffled (no matter if the new checkbox is checked or not). Type something in the op_return field, and repeat the above test. Now the shuffling behavior must depend on the checkbox. The op_return output should always be first. The other outputs should be shuffled if the checkbox is checked. If it is unchecked, then the change output must be last, and preceded by the other outputs in the specified order. Click send and check the order in a block explorer.
PiRK
force-pushed
the
order_ouputs_if_op_returnwq
branch
from
325f82b
to
22b5d08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#272 implemented shuffling of outputs in transactions, with no consideration for the type of the output.
The previous implementation before that used a deterministic sorting based on the output amount and script, which by shear luck resulted in OP_RETURN outputs always being the first output because it has a zero amount.
This PR restores this behavior of putting the OP_RETURN always first, and adds a way to keep the other outputs sorted when using OP_RETURN. This is needed for crafting SLP transactions (see https://www.youtube.com/watch?v=TU1LBd9aVlc)