prop_cat_cols fails with BOM

[Manishearth]

Caught by rustc CI

The test fails when it tries to compare [[""]] with [["\u{feff}"]]. Presumably the BOM is being stripped somewhere.

#[test]
fn prop_cat_cols() {
    fn p(rows1: CsvData, rows2: CsvData) -> bool {
        let got: Vec<Vec<String>> = run_cat(
            "cat_cols", "columns", rows1.clone(), rows2.clone(), no_headers);

        let mut expected: Vec<Vec<String>> = vec![];
        let (rows1, rows2) = (rows1.to_vecs().into_iter(),
                              rows2.to_vecs().into_iter());
        for (mut r1, r2) in rows1.zip(rows2) {
            r1.extend(r2.into_iter());
            expected.push(r1);
        }
        rassert_eq!(got, expected)
    }
     assert!(p(CsvData { data: vec![CsvRecord(vec!["".into()])] },  CsvData { data: vec![CsvRecord(vec!["\u{feff}".into()])] }));
 }

[ehuss]

It looks like this also hits the prop_reverse_no_headers test as well. I'm not sure if a1165e0 fixes that as well. Seen on rust-lang/rust CI:

• Revert switch of env locking to rwlock, to fix deadlock in process spawning rust-lang/rust#82877 (comment)
• Make the Query enum a simple struct. rust-lang/rust#80891 (comment)

thread 'test_reverse::prop_reverse_no_headers' panicked at '[quickcheck] TEST FAILED (runtime error). Arguments: (CsvData { data: [[[239, 187, 191]]] })
Error: "assertion failed: `(left == right)`\n  left: `[]`,\n right: `[[\"\\u{feff}\"]]`"', /cargo/registry/src/github.com-1ecc6299db9ec823/quickcheck-0.7.1/src/tester.rs:176:28

[RalfJung]

test_frequency::prop_frequency_indexed can also fail randomly: rust-lang/rust#99601.

[RalfJung]

a1165e0 says it fixes this issue, but only exists on a branch, not in master.