Make the `Query` enum a simple struct. #80891

cjgillot · 2021-01-10T22:38:15Z

A lot of code in rustc_query_system is generic over it, only to encode an exceptional error case: query cycles.
The delayed computations are now done at cycle detection.

rust-highfive · 2021-01-10T22:38:18Z

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

cjgillot · 2021-01-11T14:07:54Z

@bors try @rust-timer queue

rust-timer · 2021-01-11T14:07:56Z

Awaiting bors try build completion.

bors · 2021-01-11T14:08:12Z

⌛ Trying commit e08e9742ba5989cdb6b27f51226311a2e6372d5a with merge dea0e5624588437b1a358664ff4c776fae7d9625...

bors · 2021-01-11T14:54:50Z

☀️ Try build successful - checks-actions
Build commit: dea0e5624588437b1a358664ff4c776fae7d9625 (dea0e5624588437b1a358664ff4c776fae7d9625)

rust-timer · 2021-01-11T14:54:52Z

Queued dea0e5624588437b1a358664ff4c776fae7d9625 with parent a2cd91c, future comparison URL.

@rustbot label: +S-waiting-on-perf

rust-timer · 2021-01-11T16:31:33Z

Finished benchmarking try commit (dea0e5624588437b1a358664ff4c776fae7d9625): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

cjgillot · 2021-02-06T14:35:38Z

@matthewjasper Do you intend to review this or do you want it reassigned?

matthewjasper · 2021-02-06T19:54:59Z

This should be reassigned, I'm don't really understand the query system implementation well enough to review this.

Mark-Simulacrum · 2021-02-08T21:58:55Z

While I review, let's kick off a more recent perf run - it seems like it's worthwhile to see if some of the mixed results (and minor regressions to bootstrap builds) from the previous one have gone away now. @bors try @rust-timer queue

rust-timer · 2021-02-08T21:58:56Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-02-08T21:59:08Z

⌛ Trying commit e08e9742ba5989cdb6b27f51226311a2e6372d5a with merge e332f2214ecfdd09201163667071ec79884b208f...

Mark-Simulacrum

This seems interesting but at least with the previous performance results not really worth it.

I left some feedback, but it's all mostly minor things and asking for documentation.

I do think it might be worth exploring either reusing or defining a Key trait and storing the Query struct as something roughly like this which might help mitigate some of the performance problems while still giving us a more readable/maintainable implementation.

struct Query<'a> {
    name: &'static str,
    key: &'a dyn Key,
}

compiler/rustc_middle/src/ty/query/plumbing.rs

The call to `ty::print::with_forced_impl_filename_line` is done when constructing the description, at the construction of the QueryStackFrame.

Mark-Simulacrum · 2021-02-20T22:46:05Z

@bors r+

(Feel free to do this yourself too, if you're just rebasing)

bors · 2021-02-20T22:46:06Z

📌 Commit ea9100f216e2fa276d9fc84dbc1f06c2e81b2bb8 has been approved by Mark-Simulacrum

cjgillot · 2021-02-21T11:23:33Z

@bors r=Mark-Simulacrum

bors · 2021-02-21T11:23:34Z

📌 Commit 903f65f has been approved by Mark-Simulacrum

bors · 2021-02-22T02:45:03Z

⌛ Testing commit 903f65f with merge c32beb4dd2a6d8e1783ba1b66999d2e1757f2ca5...

rust-log-analyzer · 2021-02-22T03:28:32Z

The job x86_64-msvc-cargo failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test test_frequency::prop_frequency_indexed ... ok

failures:

---- test_reverse::prop_reverse_no_headers stdout ----
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-779]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-786]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-792]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-798]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-804]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-810]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-817]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-823]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-830]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-836]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-843]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-849]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-855]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-862]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-869]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-874]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-882]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-887]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-893]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-899]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-905]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-911]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-918]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-924]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-931]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[["2埫G"], ["䧄穩:9"], ["~"], ["~턨"], ["x&\u{4}|"], ["r\";"], ["i&0Q"], ["D"], ["‖"], ["zᚚ"], ["B"], [" _"], ["=l?"], ["g¯Q"], [""], ["¯>< "], ["\u{8c})N"], ["2_"], ["\u{4a53a}\u{d2315}_"], [""], ["i5"], ["튢<d"], ["\u{206e}\u{fff6}"], ["\u{99}\u{6dade}톒?"], [""], ["„"], ["]L\u{e}"], ["\u{602}t"], [""], ["\u{81}?"], ["\u{603}\u{6}~!"], ["¨"], [""], [""], [""], ["\u{89}ť"], [""], ["\u{0}>\u{13}"], ["\u{5}\u{95}형&"], [""], [""], ["-Ḳ."], ["\n[\u{c}"], [""], ["뗒"], ["\u{7}:"], [""], ["\u{8d}\u{f433}\u{8a}s"], ["K\u{1d173}"], ["\u{10fffe}9mP"], ["\';:§"], [";\u{c}¬"], [" 핋J#"], ["©^"], [""], ["71X"], ["”i\u{18}"], ["¢#\u{fffb}"], ["3V+:"], ["4"], ["!\u{ea24}"], ["E"], ["+%00"], ["("], ["F~L`"], [")\u{8c}5"], ["\'\u{12}9"], ["]f"], ["\n\u{83}"], ["\u{600}\u{8c}\u{f},"], ["\u{6dd}g"], [""], ["\u{0}#"], ["^"], ["\u{f}_"], ["S"], ["\u{c}狋T\u{89}"], ["B\\"], ["\u{fff3}"], [""], ["\u{11}6\u{1d173}"], ["\u{afc69}⁊"], ["y&4"], ["_”\u{9b}"], ["4\u{9d}>"], ["逨ࣅ$"], ["\t\u{80}"], [""], ["&"], ["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["5\u{9f}$"]]`,
 right: `[["2埫G"], ["䧄穩:9"], ["~"], ["~턨"], ["x&\u{4}|"], ["r\";"], ["i&0Q"], ["D"], ["‖"], ["zᚚ"], ["B"], [" _"], ["=l?"], ["g¯Q"], [""], ["¯>< "], ["\u{8c})N"], ["2_"], ["\u{4a53a}\u{d2315}_"], [""], ["i5"], ["튢<d"], ["\u{206e}\u{fff6}"], ["\u{99}\u{6dade}톒?"], [""], ["„"], ["]L\u{e}"], ["\u{602}t"], [""], ["\u{81}?"], ["\u{603}\u{6}~!"], ["¨"], [""], [""], [""], ["\u{89}ť"], [""], ["\u{0}>\u{13}"], ["\u{5}\u{95}형&"], [""], [""], ["-Ḳ."], ["\n[\u{c}"], [""], ["뗒"], ["\u{7}:"], [""], ["\u{8d}\u{f433}\u{8a}s"], ["K\u{1d173}"], ["\u{10fffe}9mP"], ["\';:§"], [";\u{c}¬"], [" 핋J#"], ["©^"], [""], ["71X"], ["”i\u{18}"], ["¢#\u{fffb}"], ["3V+:"], ["4"], ["!\u{ea24}"], ["E"], ["+%00"], ["("], ["F~L`"], [")\u{8c}5"], ["\'\u{12}9"], ["]f"], ["\n\u{83}"], ["\u{600}\u{8c}\u{f},"], ["\u{6dd}g"], [""], ["\u{0}#"], ["^"], ["\u{f}_"], ["S"], ["\u{c}狋T\u{89}"], ["B\\"], ["\u{fff3}"], [""], ["\u{11}6\u{1d173}"], ["\u{afc69}⁊"], ["y&4"], ["_”\u{9b}"], ["4\u{9d}>"], ["逨ࣅ$"], ["\t\u{80}"], [""], ["&"], ["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["\u{feff}5\u{9f}$"]]`', tests\test_reverse.rs:22:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-941]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-947]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-952]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[["2埫G"], ["K\u{1d173}"], ["\u{10fffe}9mP"], ["\';:§"], [";\u{c}¬"], [" 핋J#"], ["©^"], [""], ["71X"], ["”i\u{18}"], ["¢#\u{fffb}"], ["3V+:"], ["4"], ["!\u{ea24}"], ["E"], ["+%00"], ["("], ["F~L`"], [")\u{8c}5"], ["\'\u{12}9"], ["]f"], ["\n\u{83}"], ["\u{600}\u{8c}\u{f},"], ["\u{6dd}g"], [""], ["\u{0}#"], ["^"], ["\u{f}_"], ["S"], ["\u{c}狋T\u{89}"], ["B\\"], ["\u{fff3}"], [""], ["\u{11}6\u{1d173}"], ["\u{afc69}⁊"], ["y&4"], ["_”\u{9b}"], ["4\u{9d}>"], ["逨ࣅ$"], ["\t\u{80}"], [""], ["&"], ["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["5\u{9f}$"]]`,
 right: `[["2埫G"], ["K\u{1d173}"], ["\u{10fffe}9mP"], ["\';:§"], [";\u{c}¬"], [" 핋J#"], ["©^"], [""], ["71X"], ["”i\u{18}"], ["¢#\u{fffb}"], ["3V+:"], ["4"], ["!\u{ea24}"], ["E"], ["+%00"], ["("], ["F~L`"], [")\u{8c}5"], ["\'\u{12}9"], ["]f"], ["\n\u{83}"], ["\u{600}\u{8c}\u{f},"], ["\u{6dd}g"], [""], ["\u{0}#"], ["^"], ["\u{f}_"], ["S"], ["\u{c}狋T\u{89}"], ["B\\"], ["\u{fff3}"], [""], ["\u{11}6\u{1d173}"], ["\u{afc69}⁊"], ["y&4"], ["_”\u{9b}"], ["4\u{9d}>"], ["逨ࣅ$"], ["\t\u{80}"], [""], ["&"], ["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["\u{feff}5\u{9f}$"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-958]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-965]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-970]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[[""], ["\u{0}#"], ["^"], ["\u{f}_"], ["S"], ["\u{c}狋T\u{89}"], ["B\\"], ["\u{fff3}"], [""], ["\u{11}6\u{1d173}"], ["\u{afc69}⁊"], ["y&4"], ["_”\u{9b}"], ["4\u{9d}>"], ["逨ࣅ$"], ["\t\u{80}"], [""], ["&"], ["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["5\u{9f}$"]]`,
 right: `[[""], ["\u{0}#"], ["^"], ["\u{f}_"], ["S"], ["\u{c}狋T\u{89}"], ["B\\"], ["\u{fff3}"], [""], ["\u{11}6\u{1d173}"], ["\u{afc69}⁊"], ["y&4"], ["_”\u{9b}"], ["4\u{9d}>"], ["逨ࣅ$"], ["\t\u{80}"], [""], ["&"], ["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["\u{feff}5\u{9f}$"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-978]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-983]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-989]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[["_”\u{9b}"], ["4\u{9d}>"], ["逨ࣅ$"], ["\t\u{80}"], [""], ["&"], ["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["5\u{9f}$"]]`,
 right: `[["_”\u{9b}"], ["4\u{9d}>"], ["逨ࣅ$"], ["\t\u{80}"], [""], ["&"], ["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["\u{feff}5\u{9f}$"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-993]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1000]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1006]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["5\u{9f}$"]]`,
 right: `[["‖"], [""], ["`G¥"], ["~𥻴\u{14}―"], ["⁓⁔"], ["\u{feff}5\u{9f}$"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1012]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1017]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1023]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[["~𥻴\u{14}―"], ["⁓⁔"], ["5\u{9f}$"]]`,
 right: `[["~𥻴\u{14}―"], ["⁓⁔"], ["\u{feff}5\u{9f}$"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1027]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1034]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1039]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[["~𥻴\u{14}―"], ["5\u{9f}$"]]`,
 right: `[["~𥻴\u{14}―"], ["\u{feff}5\u{9f}$"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1045]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1050]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1057]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[["5\u{9f}$"]]`,
 right: `[["\u{feff}5\u{9f}$"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1061]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1068]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1073]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1079]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[["5"]]`,
 right: `[["\u{feff}5"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1084]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1092]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1094]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1102]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at 'assertion failed: `(left == right)`
  left: `[]`,
 right: `[["\u{feff}"]]`', tests\test_reverse.rs:22:5
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1107]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1113]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1118]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1125]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1129]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1136]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1142]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1147]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1153]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1160]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1165]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1171]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1177]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1184]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1190]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1197]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
[D:\a\rust\rust\build\ct\xsv\target\debug\xit\prop_reverse_no_headers\test-1202]: "D:\\a\\rust\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "reverse" "in.csv" "--no-headers"
thread 'test_reverse::prop_reverse_no_headers' panicked at '[quickcheck] TEST FAILED (runtime error). Arguments: (CsvData { data: [[[239, 187, 191]]] })
Error: "assertion failed: `(left == right)`\n  left: `[]`,\n right: `[[\"\\u{feff}\"]]`"', C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\quickcheck-0.7.1\src\tester.rs:176:28

failures:
    test_reverse::prop_reverse_no_headers

bors · 2021-02-22T03:29:45Z

💔 Test failed - checks-actions

cjgillot · 2021-02-23T18:28:32Z

I can't reproduce the failure.
@bors retry

bors · 2021-02-24T03:29:04Z

⌛ Testing commit 903f65f with merge 301ad8a...

bors · 2021-02-24T07:23:49Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 301ad8a to master...

rust-highfive assigned matthewjasper Jan 10, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2021

This comment has been minimized.

Sign in to view

cjgillot force-pushed the noq branch from f89c534 to e08e974 Compare January 10, 2021 22:45

camelid added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jan 10, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2021

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2021

Mark-Simulacrum assigned Mark-Simulacrum and unassigned matthewjasper Feb 6, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 8, 2021

Mark-Simulacrum reviewed Feb 8, 2021

View reviewed changes

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2021

cjgillot force-pushed the noq branch from 6917615 to 80b9d93 Compare February 20, 2021 21:54

This comment has been minimized.

Sign in to view

cjgillot added 2 commits February 20, 2021 23:36

Move report_cycle to rustc_query_system.

c26d965

The call to `ty::print::with_forced_impl_filename_line` is done when constructing the description, at the construction of the QueryStackFrame.

Move print_query_stack to rustc_query_system.

a87de89

cjgillot force-pushed the noq branch from 80b9d93 to ea9100f Compare February 20, 2021 22:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 20, 2021

This comment has been minimized.

Sign in to view

Simplify hashing.

903f65f

cjgillot force-pushed the noq branch from 7251ac6 to 903f65f Compare February 21, 2021 11:22

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 22, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 24, 2021

bors merged commit 301ad8a into rust-lang:master Feb 24, 2021

rustbot added this to the 1.52.0 milestone Feb 24, 2021

cjgillot deleted the noq branch February 24, 2021 09:52

ehuss mentioned this pull request Mar 8, 2021

prop_cat_cols fails with BOM BurntSushi/xsv#227

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the `Query` enum a simple struct. #80891

Make the `Query` enum a simple struct. #80891

cjgillot commented Jan 10, 2021

rust-highfive commented Jan 10, 2021

This comment has been minimized.

cjgillot commented Jan 11, 2021

rust-timer commented Jan 11, 2021

bors commented Jan 11, 2021

bors commented Jan 11, 2021

rust-timer commented Jan 11, 2021

rust-timer commented Jan 11, 2021

cjgillot commented Feb 6, 2021

matthewjasper commented Feb 6, 2021

Mark-Simulacrum commented Feb 8, 2021

rust-timer commented Feb 8, 2021

bors commented Feb 8, 2021

Mark-Simulacrum left a comment

This comment has been minimized.

Mark-Simulacrum commented Feb 20, 2021

bors commented Feb 20, 2021

This comment has been minimized.

cjgillot commented Feb 21, 2021

bors commented Feb 21, 2021

bors commented Feb 22, 2021

rust-log-analyzer commented Feb 22, 2021

bors commented Feb 22, 2021

cjgillot commented Feb 23, 2021

bors commented Feb 24, 2021

bors commented Feb 24, 2021

Make the Query enum a simple struct. #80891

Make the Query enum a simple struct. #80891

Conversation

cjgillot commented Jan 10, 2021

rust-highfive commented Jan 10, 2021

This comment has been minimized.

cjgillot commented Jan 11, 2021

rust-timer commented Jan 11, 2021

bors commented Jan 11, 2021

bors commented Jan 11, 2021

rust-timer commented Jan 11, 2021

rust-timer commented Jan 11, 2021

cjgillot commented Feb 6, 2021

matthewjasper commented Feb 6, 2021

Mark-Simulacrum commented Feb 8, 2021

rust-timer commented Feb 8, 2021

bors commented Feb 8, 2021

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

This comment has been minimized.

Mark-Simulacrum commented Feb 20, 2021

bors commented Feb 20, 2021

This comment has been minimized.

cjgillot commented Feb 21, 2021

bors commented Feb 21, 2021

bors commented Feb 22, 2021

rust-log-analyzer commented Feb 22, 2021

bors commented Feb 22, 2021

cjgillot commented Feb 23, 2021

bors commented Feb 24, 2021

bors commented Feb 24, 2021

Make the `Query` enum a simple struct. #80891

Make the `Query` enum a simple struct. #80891