Implemented S3 integration #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
requested changes
Apr 22, 2024
QuanMPhm
force-pushed
the
21/containerize
branch
from
dda6c6a
to
2938f09
Compare
|
@knikolla The build action currently does not work because the repo is missing a |
knikolla
requested changes
Apr 22, 2024
See comment above. That file shouldn't be part of container image. |
QuanMPhm
force-pushed
the
21/containerize
branch
from
2938f09
to
dba44b4
Compare
knikolla
reviewed
Apr 22, 2024
QuanMPhm
force-pushed
the
21/containerize
branch
from
dba44b4
to
7ca35e9
Compare
knikolla
requested changes
Apr 22, 2024
knikolla
changed the title
QuanMPhm
force-pushed
the
21/containerize
branch
from
7ca35e9
to
4664208
Compare
knikolla
requested changes
Apr 23, 2024
QuanMPhm
force-pushed
the
21/containerize
branch
from
4664208
to
ca2772f
Compare
naved001
reviewed
Apr 23, 2024
QuanMPhm
force-pushed
the
21/containerize
branch
from
ca2772f
to
90c4091
Compare
knikolla
requested changes
Apr 23, 2024
QuanMPhm
force-pushed
the
21/containerize
branch
from
90c4091
to
c852c30
Compare
knikolla
reviewed
Apr 23, 2024
QuanMPhm
force-pushed
the
21/containerize
branch
from
c852c30
to
5c2ef61
Compare
naved001
reviewed
Apr 24, 2024
This commit gives the user the option fetch invoices from S3 storage. Several env vars are needed to authenticate to S3 storage.
More details on these vars can be found in the function `get_invoice_bucket()` from `process_report.py`
Note that the user can provide filenames containing "{}" to inject the invoice month, allowing for some convenient formatting
QuanMPhm
force-pushed
the
21/containerize
branch
from
5c2ef61
to
6d74b3d
Compare
naved001
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completing the first half of #21. I modified the invoice script to give the user the option to fetch invoices from S3 storage, as well as to upload them to S3.
The filenames for invoices to be stored locally and in S3 is determined by the user. The script expects several env vars to be sent to perform authentication to S3
The connection to Backblaze B2 is done in the Python script through
boto3.This PR will be followed-up with a PR to containerize the invoice processing.