Added option to fetch and upload old PI file to from and to S3, and added logic to update old PI file #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
requested changes
Apr 25, 2024
|
I've added some small features and have updated the PR summary |
knikolla
requested changes
Apr 25, 2024
QuanMPhm
force-pushed
the
27/old_pi
branch
2 times, most recently
from
62d985f
to
8505314
Compare
knikolla
requested changes
Apr 25, 2024
naved001
requested changes
Apr 29, 2024
naved001
approved these changes
Apr 29, 2024
|
@QuanMPhm maybe the order you proposed the PRs. You'll need to fix the merge conflicts on both PRs though. |
…and uploaded back to S3 Also provides logic for cases where future PIs are encountered in past invoices, in which case they will be considered new PIs for the purpose of the New PI credit, and their first-month date will be changed to the past invoice's date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #27. If the user does not provide an old_pi file,
process_report.pywill by default fetch the file from a hardcoded location in S3 storage.Setting the
upload-to-s3option will now upload both the processed CSV invoices and the updated PI file.I've also renamed some functions for consistent capitalization.
I have also added a few print statements to provide the following info:
It should be noted that if future PIs are encountered when processing old invoices, the invoice script will consider them new PIs for the purpose of the new PI credit, and will update the future PI's first-month date to be same as the old invoice's date.
Blocked on #23, and prerequisite to #21