Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release staging #270

Closed
wants to merge 57 commits into from
Closed

New release staging #270

wants to merge 57 commits into from

Conversation

wkdewey
Copy link
Contributor

@wkdewey wkdewey commented Nov 21, 2022

Replaces #269 (release/4.0.0). I cherry-picked the last 20 commits.

@wkdewey
include alternate facet with facet array
6412096
@wkdewey
match incoming facet name with alternate
20dbb3b
@wkdewey
find original facet and link to it
6d15d2d
@wkdewey
account for alternate name in facet browsing
42c8369
@wkdewey
check for proper matching page when facet is paired with alternate
93787da
@wkdewey
use alternate so that facet result can be found
6da5f1d
@wkdewey
use original facet instead of alternate in links
081f078
@wkdewey
link to original facet instead of alternate in sidebar panels
1bc33cd
@wkdewey
use original facet for panel opening, selection, and removal
cf90df9
@wkdewey
add param to toggle showing label
d1d4921
@wkdewey
add missing end
f3299c1
@wkdewey
use home path instead of search path
2af2249
@wkdewey
remove byebug
143f931
@wkdewey
remove extraneous character
7d6220b
@wkdewey
add selected box in a way that accords with new faceting system
326fa48
@wkdewey
use original facet to check params
b022280
@wkdewey
use original facet name to clear search
fcc15cb
@wkdewey
account for date.year when marking and removing selected facet
0a8dee0
@wkdewey
restore old, working remove_facet method
5980892
@wkdewey
Copy link
Contributor Author

wkdewey commented Nov 22, 2022

The pull requests and branches should be in order now. ‘Release v/4.0.0 has been renamed to new_release_staging. My other branches have been rebased or cherry picked on top of that one. These changes resulted in several PR’s being closed (since they were based on the closed branch). I created new PR’s and linked to the old ones. Especially #269 which had some commentary. The order is new_release_staging -> rails6 -> rails6_ruby3 -> deep_faceting -> new_release_documentation

On the config code that was confusing: The API expects an array of facets under the key “f”. The config file code reconstructs this array for the new api functionality (a sub array with the parseable original facet name and the alternate name that can be used as an aggregation name). This array gets initialized in app/services/api_bridge/query.rb and put into the options hash for the api query in the prepare_options method. I don't think a hash can substitue for my [original_facet, aggregation_name] subarray. I will make more documentation in the code.

@wkdewey
change facet_num to facet_limit
47caa75
@wkdewey
move search to top and add instructions
63263d7
@wkdewey
update changelog for new release
a29e172
@wkdewey
update references to ruby and rails versions
76ccf88
@wkdewey
add links to more detailed documentation
8e02ebf
@wkdewey
clarify variable name in facet array
d93b5f8 
change alternate to aggregation_name
fix typos
@wkdewey
add documentation explaining use of multiple facet names
7f1a888 
nested bucket aggregation functionality with facet-related code
sometimes code needs the format rdf.predicate[rdf.type#case_role] from config, for api queries
sometimes code needs the aggregation name (i.e. case_roles) that will be in the api response
@wkdewey
change field names to match updated api
2d753db 
fixes #276
This was linked to issues Dec 6, 2022
Documentation for latest release #261
Open
metadata and API schema #276
Open
wkdewey and others added 12 commits December 19, 2022 11:53
@wkdewey wkdewey linked an issue Jun 1, 2023 that may be closed by this pull request
Fix search interface #289
Open
2 tasks
@wkdewey wkdewey linked an issue Jan 8, 2024 that may be closed by this pull request
Labels on summary boxes #295
Open
@wkdewey
Copy link
Contributor Author

wkdewey commented Aug 21, 2024

I think this is redundant to #301

@wkdewey wkdewey closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karindalziel karindalziel Awaiting requested review from karindalziel

@techgique techgique Awaiting requested review from techgique

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labels on summary boxes Fix search interface metadata and API schema Documentation for latest release
1 participant
@wkdewey