Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New release staging #270

Closed
wants to merge 57 commits into from
Closed

New release staging #270

Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
6412096
include alternate facet with facet array
wkdewey May 26, 2022
20dbb3b
match incoming facet name with alternate
wkdewey May 31, 2022
6d15d2d
find original facet and link to it
wkdewey Jun 1, 2022
42c8369
account for alternate name in facet browsing
wkdewey Jun 2, 2022
93787da
check for proper matching page when facet is paired with alternate
wkdewey Jun 2, 2022
6da5f1d
use alternate so that facet result can be found
wkdewey Jun 2, 2022
081f078
use original facet instead of alternate in links
wkdewey Jun 2, 2022
1bc33cd
link to original facet instead of alternate in sidebar panels
wkdewey Jun 2, 2022
cf90df9
use original facet for panel opening, selection, and removal
wkdewey Jul 11, 2022
d1d4921
add param to toggle showing label
wkdewey Jul 11, 2022
f3299c1
add missing end
wkdewey Aug 29, 2022
2af2249
use home path instead of search path
wkdewey Aug 29, 2022
143f931
remove byebug
wkdewey Aug 29, 2022
7d6220b
remove extraneous character
wkdewey Aug 30, 2022
326fa48
add selected box in a way that accords with new faceting system
wkdewey Sep 9, 2022
b022280
use original facet to check params
wkdewey Sep 9, 2022
fcc15cb
use original facet name to clear search
wkdewey Sep 14, 2022
0a8dee0
account for date.year when marking and removing selected facet
wkdewey Sep 15, 2022
5980892
restore old, working remove_facet method
wkdewey Oct 20, 2022
41665f7
change comments from html style to erb style
wkdewey Jan 6, 2022
6571b6e
Adjust browse display according to selected facets
wkdewey Jun 15, 2022
0ca9b76
add button to see search results
wkdewey Jun 15, 2022
ede1ebe
use alternate so that facet result can be found
wkdewey Jun 2, 2022
7b06a59
use original facet instead of alternate in links
wkdewey Jun 2, 2022
83e6715
add missing end
wkdewey Aug 29, 2022
6dce4b2
use home path instead of search path
wkdewey Aug 29, 2022
5f28c5d
add selected box in a way that accords with new faceting system
wkdewey Sep 9, 2022
7466246
account for date.year when marking and removing selected facet
wkdewey Sep 15, 2022
88c6bef
restore old, working remove_facet method
wkdewey Oct 20, 2022
fb5d68f
search for value key
wkdewey Oct 21, 2022
b374a34
Update CHANGELOG.md
wkdewey May 17, 2022
65254be
raise default facet limit
wkdewey Oct 31, 2022
facb291
don't show see more unless more facets than the limit
wkdewey Oct 31, 2022
9323d75
raise facet limit for sections
wkdewey Oct 31, 2022
a4d833e
set facet_limit variable in the controller
wkdewey Nov 1, 2022
47caa75
change facet_num to facet_limit
wkdewey Nov 1, 2022
63263d7
move search to top and add instructions
wkdewey Nov 1, 2022
a29e172
update changelog for new release
wkdewey Nov 7, 2022
76ccf88
update references to ruby and rails versions
wkdewey Nov 7, 2022
8e02ebf
add links to more detailed documentation
wkdewey Nov 10, 2022
d93b5f8
clarify variable name in facet array
wkdewey Nov 22, 2022
7f1a888
add documentation explaining use of multiple facet names
wkdewey Nov 28, 2022
2d753db
change field names to match updated api
wkdewey Dec 5, 2022
9ecae08
update field name for works
wkdewey Dec 19, 2022
4573779
make sure helper methods have Jess's work from feature/api1.1 branch
wkdewey Dec 19, 2022
40f286c
display only the result count from api response
wkdewey Dec 19, 2022
acc74fd
add param to toggle showing label
wkdewey Jul 11, 2022
be8f153
remove check_response where res is not api reponse
wkdewey Jan 12, 2023
96d16e3
filter facets from search query if not marked "search filter"
wkdewey Jan 31, 2023
5aa5631
retain section param for ApiBridge::Query
wkdewey Jan 31, 2023
52efb61
direct search button to search path
wkdewey Feb 1, 2023
7150841
Remove value_label, replace with facet_label
wkdewey Feb 1, 2023
d1a4d19
fix ApiBridge query method
wkdewey Mar 5, 2023
9b7c264
show search button only if search params present
wkdewey Jun 1, 2023
9db98f3
Add sort menu and pass in search params
wkdewey Jun 1, 2023
00bc7eb
fix bug where metadata method wouldn't accept a single hash for a nes…
wkdewey Nov 29, 2023
f0f9644
fix how selected facet is displayed in summary boxes
wkdewey Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
direct search button to search path 
fixes #283
  • Loading branch information
@wkdewey
wkdewey committed Feb 1, 2023
commit 52efb6135aa9a8c95af405fc04e436e11ac54001
2 changes: 1 addition & 1 deletion app/views/items/browse_facet.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
</ul>
</nav>
<p>Select facets listed below, then click "search" to see search results</p>
<%= link_to "Search", prefix_path("home_path", f: params[:f]), rel: "nofollow", class: "btn btn-default" %>
<%= link_to "Search", prefix_path("search_path", f: params[:f]), rel: "nofollow", class: "btn btn-default" %>
<div class="tab-content">
<% @page_facets.each_with_index do |(facet_name, facet_info), index| %>
<% id = facet_name.parameterize(separator: ".") %>
Expand Down