Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_partial_result #135

Merged
merged 5 commits into from
May 9, 2023
Merged

Conversation

yao-cqc
Copy link
Contributor

@yao-cqc yao-cqc commented May 4, 2023

Websocket only message back on status change, therefore it is not useful for retrieving partial results. I decided to add a simple method that makes a single call to the endpoint. It's up to the user to decide how they want to use this method and process data.

@yao-cqc yao-cqc marked this pull request as ready for review May 5, 2023 09:07
@yao-cqc yao-cqc requested a review from cqc-alec May 5, 2023 09:08
@yao-cqc
Copy link
Contributor Author

yao-cqc commented May 5, 2023

It seems H1-2E isn't responding. Will rerun the tests

:type handle: ResultHandle

:return: A tuple containing the results and circuit status.
If no results are available, the first element is None.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an indent here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree!

cqc-alec
cqc-alec previously approved these changes May 5, 2023
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cqc-melf
Copy link
Collaborator

cqc-melf commented May 5, 2023

I hope this should fix the issue with the version, it would be great if we would not need to update the ci workflow

@yao-cqc
Copy link
Contributor Author

yao-cqc commented May 5, 2023

The CI failure is caused by the stabiliser simulator keeping non-Clifford circuits in a forever running state. Will check with them.

@cqc-alec cqc-alec merged commit 5ed109f into develop May 9, 2023
@cqc-alec cqc-alec deleted the feature/retrieving-partial-results branch May 9, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants