Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to device/system family. #137

Merged
merged 3 commits into from
May 9, 2023
Merged

Conversation

cqc-alec
Copy link
Collaborator

@cqc-alec cqc-alec commented May 9, 2023

This is no longer a thing that devices report.

Fixes #136 .

@cqc-alec cqc-alec requested a review from cqc-melf May 9, 2023 10:43
@cqc-alec cqc-alec requested a review from yao-cqc as a code owner May 9, 2023 10:43
Copy link
Collaborator

@cqc-melf cqc-melf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation needs to be updated as well?

See https://cqcl.github.io/pytket-quantinuum/api/index.html#devices
* ``H1``: Submit to Quantinuum ``H1`` machines: job is run on ``H1-1`` or ``H1-2`` based on the soonest available device.

https://github.com/CQCL/pytket-quantinuum/blob/feature/nofamily/docs/intro.txt

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented May 9, 2023

I think the documentation needs to be updated as well?

See https://cqcl.github.io/pytket-quantinuum/api/index.html#devices *H1: Submit to Quantinuum H1machines: job is run onH1-1orH1-2based on the soonest available device.

Thanks, done.

@cqc-alec cqc-alec requested a review from cqc-melf May 9, 2023 10:53
@cqc-melf
Copy link
Collaborator

cqc-melf commented May 9, 2023

And one more: https://github.com/CQCL/pytket-quantinuum/blob/feature/nofamily/pytket/extensions/quantinuum/backends/quantinuum.py#LL196C9-L196C54

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented May 9, 2023

And one more: https://github.com/CQCL/pytket-quantinuum/blob/feature/nofamily/pytket/extensions/quantinuum/backends/quantinuum.py#LL196C9-L196C54

Done.

@cqc-melf
Copy link
Collaborator

cqc-melf commented May 9, 2023

Should we put out a release candidate or a new documentation to make sure this is out soon?

@cqc-alec
Copy link
Collaborator Author

cqc-alec commented May 9, 2023

Should we put out a release candidate or a new documentation to make sure this is out soon?

I think we should do a release as soon as #135 is merged, since people are asking for that.

@cqc-alec cqc-alec merged commit bb7cd43 into develop May 9, 2023
@cqc-alec cqc-alec deleted the feature/nofamily branch May 9, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove device families from documentation
2 participants