Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lib/trie): refactor encoding and hash related code in trie package #2077

Merged
merged 50 commits into from
Dec 16, 2021
Merged

chore(lib/trie): refactor encoding and hash related code in trie package #2077

merged 50 commits into from
Dec 16, 2021

Commits on Dec 13, 2021

  1. export all trie node methods

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    ccf0218 View commit details
    Browse the repository at this point in the history

  2. Export node interface

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    c94b882 View commit details
    Browse the repository at this point in the history

  3. export branch

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a10fd38 View commit details
    Browse the repository at this point in the history

  4. export leaf struct

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    b6fc29e View commit details
    Browse the repository at this point in the history

  5. Add exported comments

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    5bc7d18 View commit details
    Browse the repository at this point in the history

  6. Refactor encoding and hash related code with tests

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    59ab003 View commit details
    Browse the repository at this point in the history

  7. Address TODOs

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d87deba View commit details
    Browse the repository at this point in the history

  8. Remove no longer needed mocks

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    77e4203 View commit details
    Browse the repository at this point in the history

  9. Fix encode decode tests

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d5f06a4 View commit details
    Browse the repository at this point in the history

  10. Remove old parallel related code

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    07c52c2 View commit details
    Browse the repository at this point in the history

  11. Fix eventual bad type assertion

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    4a7cb4c View commit details
    Browse the repository at this point in the history

  12. Remove commented Decode method in node interface

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    0063885 View commit details
    Browse the repository at this point in the history

  13. chore(lib/trie): lib/trie/recorder sub-package (#2082) 

    * `lib/trie/recorder` subpackage

* return an error on a call to Next() with no node

* remove recorder `IsEmpty` method

* Recorder `GetNodes()`
    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a3ee3a7 View commit details
    Browse the repository at this point in the history

  14. Remove ReadNextByte and use sync.Pool

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    e77adb2 View commit details
    Browse the repository at this point in the history

  15. Rename ExtraPartialKeyLength to KeyLength

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8697d2d View commit details
    Browse the repository at this point in the history

  16. Remove unneded NibblesToKey

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    b03ecff View commit details
    Browse the repository at this point in the history

  17. Rename Header() to encodeHeader()

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    207a5c3 View commit details
    Browse the repository at this point in the history

  18. encode headers directly to buffer

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    37425a7 View commit details
    Browse the repository at this point in the history

  19. Merge packages in lib/trie/node 

    - `lib/trie/leaf`
- `lib/trie/branch`
- `lib/trie/encode`
- `lib/trie/decode`
    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    301188d View commit details
    Browse the repository at this point in the history

  20. lib/trie/node -> internal/trie/node

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d35fc0f View commit details
    Browse the repository at this point in the history

  21. Simplify and fix mock generations

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    9df5d2c View commit details
    Browse the repository at this point in the history

  22. Add licenses

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d65d600 View commit details
    Browse the repository at this point in the history

  23. Use Node instead of node.Node in lib/trie

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a443ac5 View commit details
    Browse the repository at this point in the history

  24. lib/trie/recorder -> internal/trie/recorder

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    d1e21cc View commit details
    Browse the repository at this point in the history

  25. lib/trie/pools -> internal/trie/pools

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    4721f25 View commit details
    Browse the repository at this point in the history

  26. lib/trie/codec -> internal/trie/codec

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8cd2ebb View commit details
    Browse the repository at this point in the history

  27. Node interface named returns

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1c53578 View commit details
    Browse the repository at this point in the history

  28. Use bytes.NewReader for readers

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    79c2ecb View commit details
    Browse the repository at this point in the history

  29. Add GetValue method to node interface

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    5cce780 View commit details
    Browse the repository at this point in the history

  30. Add GetKey method to node interface

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    5b800f1 View commit details
    Browse the repository at this point in the history

  31. node.Decode function

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    93ee8b6 View commit details
    Browse the repository at this point in the history

  32. Apply suggestions from @kishansagathiya's code review 

    Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
    @qdm12 @kishansagathiya
    qdm12 and kishansagathiya authored Dec 13, 2021
    Configuration menu
    Copy the full SHA
    c054516 View commit details
    Browse the repository at this point in the history

  33. Improve ScaleEncodeHash error wrapping

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    87f058d View commit details
    Browse the repository at this point in the history

  34. Shorten children bitmap bitwise or

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    9fd4036 View commit details
    Browse the repository at this point in the history

  35. Add comments for Dirty and Generation

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    2feebe7 View commit details
    Browse the repository at this point in the history

  36. Unexport Generation node field

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8c213df View commit details
    Browse the repository at this point in the history

  37. Unexport Dirty field for node

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    db578d4 View commit details
    Browse the repository at this point in the history

  38. Unexport node's Hash as hashDigest

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    a4da41a View commit details
    Browse the repository at this point in the history

  39. Trie string does not cache encoding in nodes

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    89bf885 View commit details
    Browse the repository at this point in the history

  40. Unexport node's Encoding field

    @qdm12
    qdm12 committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    23560c6 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Fix NewBranch to NewLeaf

    @qdm12
    qdm12 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    1837d85 View commit details
    Browse the repository at this point in the history

  2. Add node type comments in tests

    @qdm12
    qdm12 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    3129e79 View commit details
    Browse the repository at this point in the history

  3. Use node.Type for Type constants

    @qdm12
    qdm12 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    7503f21 View commit details
    Browse the repository at this point in the history

  4. keyLenOffset constant 0x3f

    @qdm12
    qdm12 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e17c08e View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Fix comment (@noot suggestion)

    @qdm12
    qdm12 committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    865aae6 View commit details
    Browse the repository at this point in the history

  2. Updated generation comment

    @qdm12
    qdm12 committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    8c31788 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. fix copy functions to copy nil slices correctly

    @qdm12
    qdm12 committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    831213c View commit details
    Browse the repository at this point in the history

  2. Move leaf hash methods to hash.go

    @qdm12
    qdm12 committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    8a315af View commit details
    Browse the repository at this point in the history

  3. fix naming in decodeKey function

    @qdm12
    qdm12 committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    9c73b48 View commit details
    Browse the repository at this point in the history

  4. 95.7% test coverage for internal/trie/node

    @qdm12
    qdm12 committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    61baed1 View commit details
    Browse the repository at this point in the history