tests(dot/digest) add tests to digest block import handler #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mportHandler` at `digest` pkg
…e/gossamer into eclesio/handle-digest-on-import
…e/gossamer into eclesio/handle-digest-on-import
EclesioMeloJunior
requested review from
edwardmack,
timwu20,
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3329 +/- ##
===============================================
+ Coverage 51.01% 51.42% +0.41%
===============================================
Files 224 224
Lines 28118 28125 +7
===============================================
+ Hits 14343 14464 +121
+ Misses 12391 12270 -121
- Partials 1384 1391 +7 |
kanishkatn
reviewed
Jun 19, 2023
kanishkatn
approved these changes
Jun 19, 2023
jimjbrettj
reviewed
Jun 20, 2023
jimjbrettj
reviewed
Jun 20, 2023
jimjbrettj
approved these changes
Jun 20, 2023
…b.com:ChainSafe/gossamer into eclesio/add-tests-digest-block-import-handler
jimjbrettj
approved these changes
Jun 20, 2023
EclesioMeloJunior
deleted the
eclesio/add-tests-digest-block-import-handler
branch
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
digest.BlockImportHandlernow returns an error when failing to handle a consensus digestBlockImportHandlerand remove channel #3312Tests
go test -run github.com/ChainSafe/gossamer/dot/digestIssues
N/A
Primary Reviewer
@axaysagathiya