Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(dot/digest) add tests to digest block import handler #3329

Merged
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ed49a98
chore: update `core.Service` to handle a digest on `handleBlock` method
EclesioMeloJunior Jun 12, 2023
5a306fa
chore: remove the `handleBlockImport` goroutine and introduce `BlockI…
EclesioMeloJunior Jun 12, 2023
3a96dc2
chore: start fixing tests
EclesioMeloJunior Jun 12, 2023
93f0a9e
chore: regenerate mocks and fix digest handler service parameters
EclesioMeloJunior Jun 12, 2023
fa42a85
chore: add license to `digest/block_import.go`
EclesioMeloJunior Jun 12, 2023
45f72d6
chore: solve a unexepected param at `verify_integration_test.go`
EclesioMeloJunior Jun 12, 2023
29d12fe
chore: solve tests failures at `dot/core` pkg
EclesioMeloJunior Jun 13, 2023
57a15c8
Merge branch 'development' into eclesio/handle-digest-on-import
EclesioMeloJunior Jun 13, 2023
0a6abb7
chore: solve problems at test `TestHandler_GrandpaForcedChange`
EclesioMeloJunior Jun 13, 2023
94282b2
Merge branch 'eclesio/handle-digest-on-import' of github.com:ChainSaf…
EclesioMeloJunior Jun 13, 2023
4536210
chore: solve tests at `dot/digest` pkg
EclesioMeloJunior Jun 13, 2023
70e4cf9
Merge branch 'development' into eclesio/handle-digest-on-import
EclesioMeloJunior Jun 14, 2023
f042095
chore: fix tests on babe pkg
EclesioMeloJunior Jun 14, 2023
a92b9e2
Merge branch 'eclesio/handle-digest-on-import' of github.com:ChainSaf…
EclesioMeloJunior Jun 14, 2023
28fc6ce
chore: fix `TestService_HandleTransactionMessage` test
EclesioMeloJunior Jun 14, 2023
a2dfb67
chore: solve `TestVerifyForkBlocksWithRespectiveEpochData` test
EclesioMeloJunior Jun 14, 2023
d1d17ff
feat: add tests to digest block import handler
EclesioMeloJunior Jun 15, 2023
25b833a
Merge branch 'development' into eclesio/add-tests-digest-block-import…
EclesioMeloJunior Jun 15, 2023
a4818a8
chore: add license to `bloc_import_test.go`
EclesioMeloJunior Jun 15, 2023
8a048f9
chore: fix mispell
EclesioMeloJunior Jun 15, 2023
8200a22
chore: fix line limits
EclesioMeloJunior Jun 15, 2023
542451a
chore: solve error chain at `digest.BlockImportHandler.Handle()`
EclesioMeloJunior Jun 16, 2023
d2f02d7
Merge branch 'development' into eclesio/add-tests-digest-block-import…
EclesioMeloJunior Jun 16, 2023
afaf1e4
Merge branch 'development' into eclesio/add-tests-digest-block-import…
EclesioMeloJunior Jun 20, 2023
39e5b6f
chore: remove `withDigest` type, added error context messages
EclesioMeloJunior Jun 20, 2023
6016145
Merge branch 'eclesio/add-tests-digest-block-import-handler' of githu…
EclesioMeloJunior Jun 20, 2023
a70ec26
Merge branch 'development' into eclesio/add-tests-digest-block-import…
EclesioMeloJunior Jun 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions dot/digest/block_import.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func (h *BlockImportHandler) Handle(importedBlockHeader *types.Header) error {
// https://github.com/ChainSafe/gossamer/issues/3330
err = h.grandpaState.ApplyForcedChanges(importedBlockHeader)
if err != nil {
return fmt.Errorf("while apply forced changes: %s", err)
return fmt.Errorf("while applying forced changes: %w", err)
}

return nil
Expand All @@ -53,7 +53,7 @@ func (h *BlockImportHandler) handleDigests(header *types.Header) error {
digest := consensusDigests[i]
err := h.handleConsensusDigest(&digest, header)
if err != nil {
logger.Errorf("cannot handle consensus digest: %w", err)
return err
EclesioMeloJunior marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand All @@ -69,15 +69,23 @@ func (h *BlockImportHandler) handleConsensusDigest(d *types.ConsensusDigest, hea
return err
}

return h.grandpaState.HandleGRANDPADigest(header, data)
err = h.grandpaState.HandleGRANDPADigest(header, data)
if err != nil {
return fmt.Errorf("while handling grandpa digest: %w", err)
}
return nil
EclesioMeloJunior marked this conversation as resolved.
Show resolved Hide resolved
case types.BabeEngineID:
data := types.NewBabeConsensusDigest()
err := scale.Unmarshal(d.Data, &data)
if err != nil {
return err
}

return h.epochState.HandleBABEDigest(header, data)
err = h.epochState.HandleBABEDigest(header, data)
if err != nil {
return fmt.Errorf("while handling babe digest: %w", err)
}
return nil
default:
return fmt.Errorf("%w: 0x%x", ErrUnknownConsensusEngineID, d.ConsensusEngineID.ToBytes())
}
Expand Down
Loading