-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib/parachain): Implement request and response message for /req_collation/1 protocol #3356
Merged
axaysagathiya
merged 27 commits into
ChainSafe:feat/parachain
from
axaysagathiya:issue-3339
Jul 6, 2023
Merged
feat(lib/parachain): Implement request and response message for /req_collation/1 protocol #3356
axaysagathiya
merged 27 commits into
ChainSafe:feat/parachain
from
axaysagathiya:issue-3339
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hainSafe#3281) Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com> Co-authored-by: Edward Mack <emack@pop-os.localdomain>
… to 10.14.1 (ChainSafe#3298) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ainSafe#3300) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nSafe#3151) Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Timothy Wu <tim.wu@chainsafe.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com> Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
axaysagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
June 26, 2023 09:10
jimjbrettj
reviewed
Jun 26, 2023
jimjbrettj
reviewed
Jun 26, 2023
jimjbrettj
reviewed
Jun 26, 2023
jimjbrettj
reviewed
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do not need wrappers around scale here, but otherwise looks good to me
kanishkatn
approved these changes
Jul 3, 2023
kishansagathiya
force-pushed
the
feat/parachain
branch
from
July 4, 2023 15:39
c3bd831
to
b03c606
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/parachain #3356 +/- ##
==================================================
- Coverage 51.69% 51.38% -0.31%
==================================================
Files 234 234
Lines 28677 28595 -82
==================================================
- Hits 14824 14693 -131
- Misses 12419 12476 +57
+ Partials 1434 1426 -8 |
kishansagathiya
approved these changes
Jul 5, 2023
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 12, 2023
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 12, 2023
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 14, 2023
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 27, 2023
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Aug 4, 2023
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Aug 22, 2023
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Aug 22, 2023
…collation/1 protocol (#3356)
edwardmack
pushed a commit
that referenced
this pull request
Aug 30, 2023
…collation/1 protocol (#3356)
edwardmack
pushed a commit
that referenced
this pull request
Aug 31, 2023
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Sep 14, 2023
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 23, 2024
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 24, 2024
…collation/1 protocol (#3356)
timwu20
pushed a commit
that referenced
this pull request
Jun 13, 2024
…collation/1 protocol (#3356)
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…collation/1 protocol (#3356)
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
…collation/1 protocol (#3356)
edwardmack
pushed a commit
that referenced
this pull request
Jun 26, 2024
…collation/1 protocol (#3356)
edwardmack
pushed a commit
that referenced
this pull request
Jul 12, 2024
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…collation/1 protocol (#3356)
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…collation/1 protocol (#3356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
Closes #3339
Primary Reviewer
@kanishkatn @edwardmack