Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib/parachain): Implement request and response message for /req_collation/1 protocol #3356

Merged
merged 27 commits into from
Jul 6, 2023

Conversation

axaysagathiya
Copy link
Contributor

Changes

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Closes #3339

Primary Reviewer

@kanishkatn @edwardmack

kanishkatn and others added 19 commits May 29, 2023 14:45
…hainSafe#3281)

Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>
Co-authored-by: Edward Mack <emack@pop-os.localdomain>
… to 10.14.1 (ChainSafe#3298)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ainSafe#3300)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Timothy Wu <tim.wu@chainsafe.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com>
Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need wrappers around scale here, but otherwise looks good to me

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #3356 (6f333c4) into feat/parachain (26ef0d9) will decrease coverage by 0.31%.
The diff coverage is 65.51%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           feat/parachain    #3356      +/-   ##
==================================================
- Coverage           51.69%   51.38%   -0.31%     
==================================================
  Files                 234      234              
  Lines               28677    28595      -82     
==================================================
- Hits                14824    14693     -131     
- Misses              12419    12476      +57     
+ Partials             1434     1426       -8     

lib/parachain/collation_fetching_test.go Outdated Show resolved Hide resolved
lib/parachain/collation_fetching_test.go Outdated Show resolved Hide resolved
@axaysagathiya axaysagathiya merged commit d1037b4 into ChainSafe:feat/parachain Jul 6, 2023
20 checks passed
kishansagathiya pushed a commit that referenced this pull request Jul 12, 2023
kishansagathiya pushed a commit that referenced this pull request Jul 12, 2023
kishansagathiya pushed a commit that referenced this pull request Jul 14, 2023
@axaysagathiya axaysagathiya deleted the issue-3339 branch July 21, 2023 07:14
kishansagathiya pushed a commit that referenced this pull request Jul 27, 2023
kishansagathiya pushed a commit that referenced this pull request Aug 4, 2023
kishansagathiya pushed a commit that referenced this pull request Aug 22, 2023
kishansagathiya pushed a commit that referenced this pull request Aug 22, 2023
edwardmack pushed a commit that referenced this pull request Aug 30, 2023
edwardmack pushed a commit that referenced this pull request Aug 31, 2023
kishansagathiya pushed a commit that referenced this pull request Sep 14, 2023
kishansagathiya pushed a commit that referenced this pull request Jan 23, 2024
kishansagathiya pushed a commit that referenced this pull request Jan 24, 2024
timwu20 pushed a commit that referenced this pull request Jun 13, 2024
timwu20 pushed a commit that referenced this pull request Jun 17, 2024
timwu20 pushed a commit that referenced this pull request Jun 20, 2024
edwardmack pushed a commit that referenced this pull request Jun 26, 2024
edwardmack pushed a commit that referenced this pull request Jul 12, 2024
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
kishansagathiya pushed a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants