feat(lib/parachain): Implement request and response message for /req_chunk/1 protocol #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hainSafe#3281) Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com> Co-authored-by: Edward Mack <emack@pop-os.localdomain>
… to 10.14.1 (ChainSafe#3298) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ainSafe#3300) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nSafe#3151) Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Co-authored-by: Kishan Sagathiya <kishansagathiya@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Timothy Wu <tim.wu@chainsafe.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eclésio Junior <eclesiomelo.1@gmail.com> Co-authored-by: Axay Sagathiya <axaysagathiya@gmail.com>
Co-authored-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
axaysagathiya
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
kishansagathiya
force-pushed
the
feat/parachain
branch
from
c3bd831
to
b03c606
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/parachain #3362 +/- ##
==================================================
- Coverage 51.43% 51.38% -0.06%
==================================================
Files 235 235
Lines 28706 28629 -77
==================================================
- Hits 14765 14711 -54
+ Misses 12505 12493 -12
+ Partials 1436 1425 -11 |
kishansagathiya
approved these changes
Jul 6, 2023
jimjbrettj
approved these changes
Jul 6, 2023
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 12, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 12, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 14, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 27, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Aug 4, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Aug 22, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Aug 22, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
edwardmack
pushed a commit
that referenced
this pull request
Aug 30, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
edwardmack
pushed a commit
that referenced
this pull request
Aug 31, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Sep 14, 2023
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 23, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Jan 24, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
timwu20
pushed a commit
that referenced
this pull request
Jun 13, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
timwu20
pushed a commit
that referenced
this pull request
Jun 17, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
timwu20
pushed a commit
that referenced
this pull request
Jun 20, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
edwardmack
pushed a commit
that referenced
this pull request
Jun 26, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
edwardmack
pushed a commit
that referenced
this pull request
Jul 12, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
kishansagathiya
pushed a commit
that referenced
this pull request
Jul 15, 2024
…chunk/1 protocol (#3362) - Added `ChunkFetchingRequest` and `ChunkFetchingResponse` types. - implemented network.Message interface in `ChunkFetchingRequest` and 'network.ResponseMessage' interface in `ChunkFetchingResponse`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
ChunkFetchingRequestandChunkFetchingResponsetypes.implemented 'network.Message' interface in
ChunkFetchingRequestand 'network.ResponseMessage' interface inChunkFetchingResponseas they will be passed into this function as req and res.Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Closes #3338
Primary Reviewer
@kanishkatn @edwardmack