Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dot/parachain): implement candidate validation pre-check #4223

Merged
merged 53 commits into from
Oct 9, 2024
Merged

feat(dot/parachain): implement candidate validation pre-check #4223

merged 53 commits into from
Oct 9, 2024

Conversation

edwardmack
Copy link
Member

@edwardmack edwardmack commented Oct 4, 2024 •
edited
Loading

Changes

Implement code for candidate validation pre-check subsystem.

  • precheckPvF function for determining if the validation code in valid:
    • Retrieves the validation code from the relay parent's runtime instance.
    • Determines executor parameters for pre-check.
    • Determines timeout durations
    • calls pvf host precheck function

Implements code in pvf host:

  • handlePrecheckPvF returns error if there is an issue compiling validation code
  • modify addNewWorker to accept timeout duration.

Create tests for pre-checks.

Tests

go test github.com/ChainSafe/gossamer/dot/parachain/candidate-validation

Issues

closes: #3921

@edwardmack
add pvf worker pool skeleton
50cc3ab
@edwardmack
add test to validation host
3427da0
@edwardmack
create worker pool skeleton for PVF host
6537104
@edwardmack
add validation logic to workers
7e314f3
@edwardmack
address lint issues.
0b2b5fc
@edwardmack
add functionality for validate from chainstate to pvf host and tests
20fd4c4
@edwardmack
add updated mock files
6c05d82
@edwardmack
clean-up unused comments
a6b2652
@edwardmack
Merge branch 'feat/parachain' into ed/feat/candidate_validation_pvf_h…
e978c38 
…ost_base
@edwardmack
address merge conflicts
0655dd3
@edwardmack
Merge branch 'feat/parachain' into ed/feat/candidate_validation_pvf_h…
674fefa 
…ost_base
@edwardmack
resolve merge conflicts
01905af
@edwardmack
refactor ValidationHost to Host, and validationWorkerPool to workerPool
afde6fd
@edwardmack
Merge branch 'feat/parachain' into ed/feat/candidate_validation_pvf_h…
0f25072 
…ost_base
@edwardmack
refactor go concurrancy
dbf3cf8
@edwardmack
Merge branch 'feat/parachain' into ed/feat/candidate_validation_pvf_h…
c95c3e7 
…ost_base
@edwardmack
revert run to match interface
79ba043
@edwardmack
remove redundant structs for simplicty, removed go routines to simpli…
ce721e7 
…fy code
@edwardmack
removed pvf package, simplified code removed concurrency
48faacd
@edwardmack
added missing mock file
391c6b4
@edwardmack
address deep source comments
7988888
@edwardmack
address PR comments
5820e3f
@edwardmack
make private functions/structs private
3e5ac28
@edwardmack
implement function timeout
3e6f025
@edwardmack
refactor submitRequest to executeRequest
020fb6f
@edwardmack
add test for candidate-validation timeout
cdc3514
@edwardmack
Merge branch 'ed/feat/candidate_validation_pvf_host_base' into ed/fea…
9b0f2e6 
…t/candidate_validation_confirm_errors
@edwardmack
handle validation errors InvalidOutputs and BadParent
31b83f1
@edwardmack
add addition validation timeout tests
c96f6e8
@edwardmack
address PR comments
b8bbeb2
@edwardmack edwardmack self-assigned this Oct 4, 2024
@edwardmack edwardmack marked this pull request as ready for review October 4, 2024 21:03
@edwardmack edwardmack mentioned this pull request Oct 4, 2024
Closed
haikoschol
haikoschol requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@haikoschol haikoschol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the typo in the constant name

dot/parachain/candidate-validation/messages.go Outdated Show resolved Hide resolved
dot/parachain/candidate-validation/worker_pool.go Show resolved Hide resolved
dot/parachain/candidate-validation/candidate_validation.go Show resolved Hide resolved
@edwardmack edwardmack merged commit 20b85ad into feat/parachain Oct 9, 2024
22 checks passed
@edwardmack edwardmack deleted the ed/feat/candidate_validation_precheck_sq branch October 9, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axaysagathiya axaysagathiya axaysagathiya left review comments

@haikoschol haikoschol haikoschol approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

Assignees

@edwardmack edwardmack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edwardmack @haikoschol @EclesioMeloJunior @axaysagathiya