feat(dot/parachain): implement candidate validation pre-check #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardmack
requested review from
EclesioMeloJunior,
jimjbrettj,
timwu20 and
kishansagathiya
as code owners
add updated mock files clean-up unused comments
…4067) Co-authored-by: Timothy Wu <tim.wu@chainsafe.io> test(dot/parachain/backing): make sure parachain candidate reaches quorum (#4115) - written integration test to check everything mentioned above - I re-wrote the logic to convert the attested to the backed candidate. (was not working as expected) - minor changes in dot/parachain/backing/per_relay_parent_state.go to improve the readability. test(dot/parachain/backing): validation fail does not stop the candidate backing subsystem (#4117) address merge conflicts chore(dot/parachain): improve Run method of subsystems (#4113) - I have updated the Run method of the subsystem interface to pass only necessary arguments. - removed context, context cancel func, wait group and OverseerToSubSystem channel from the state struct of all the subsystems(example: candidateBacking{}, AvailabilityStoreSubsystem{}). - improved Run method of some subsystems. - removed return type from RegisterSubsystem method of overseer. - because of these changes, some tests were failing, so I fixed those tests.
test(dot/parachain/backing): can not second multiple candidate per relay parent without prospective parachain (#4134) - I have written a test to ensure it's impossible to second multiple candidates per relay parent when prospective parachain mode is inactive(async backing is not supported). - received a candidate backing message to second a candidate. Ensured it seconds the candidate. - I received another candidate backing message to second a candidate with the same relay parent. I ensured this candidate got rejected. - Written some helper functions to reuse the code. - Added a function to stop the mockable overseer and wait some time to finish the ongoing process before exiting the test. - I have added an extra check to handle expected overseer action in the mockable overseer. - Because of this extra check, other tests failed, so I fixed them. refactor go concurrancy test(dot/parachain/backing): ensure new lead view doesn't clobber the old view (#4148)
added missing mock file address deep source comments address PR comments make private functions/structs private
address PR comments address PR comments, rename variables and functions fix test remove printf from debugging address PR comments test(dot/parachain/backing): ensure conflicting statments treated as misbehavior (#4164) fix merge conflicts
add maybeCompressedBlobDecompress function and test feat(dot/parachain): Confirm invalidity errors are implemented in candidate validation. (#4163)
statement distribution skeleton (#4169) Statement Distribution subsystem is responsible for distributing signed statements that we have generated and forwarding statements generated by our peers. This commit just introduces a skeleton for it. - implements the subsystem interface - registers the subsystem with overseer - add the processMessage method with messages to be handled Issue #3583 cleanup remove un-used code add comments regenerate mocks feat(dot/parachain): receiver side of network bridge (#3955) - handled active leaves update message - handled block finalized message - relay network protocol messages - handle view update message for receiver side of the network bridge #3864 - decode messages to wire message (PR #4188), Fixes #4108 - handle our view change in collator protocol validator side (PR #4197), Issue #4156 - Handle network bridge messages (UpdateAuthorityIDs and NewGossipTopology) Fixes #3862 - process network events for receiver side of network bridge Issue Fixes #3863 - process overseer signals for network bridge Fixes #3861
edwardmack
force-pushed
the
ed/feat/candidate_validation_precheck
branch
from
7f80875
to
2750b20
Compare
|
Closed and replaced by PR #4223. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implement code for candidate validation pre-check subsystem.
precheckPvFfunction for determining if the validation code in valid:Implements code in pvf host:
handlePrecheckPvFreturns error if there is an issue compiling validation codeaddNewWorkerto accept timeout duration.Create tests for pre-checks.
Tests
go test github.com/ChainSafe/gossamer/dot/parachain/candidate-validationIssues
closes: #3921