Update to monaco 0.45

[CGNonofr]

published as 1.85.0-next.0

also fix #289

[kaisalmen]

@CGNonofr awesome PR on release day of new VSCode. 🎉 Can you please release a preview version for testing. I will take a look at everything tomorrow morning.

I have one request/discussion point about the versioning scheme.
Example: Upgrade from 1.83.12 to 1.83.16 seems like a patch, but you know it wasn't. If I use ~1.83.12 as version selector in a dependent project you expect non-breaking changes. The only way to prevent this right now is to pin-point it to something like 1.83.12.

What do you think about the following version scheme:
185.0.0 = [vscode-version].[mva-level-changes].[mva-bugfixes]

So, new features, breaking changes will be 185.1.0, and bug fixes 185.0.1 like in regular semantic versioning. The meaning of minor is a bit stretched here, but there is at least the possibility to distinguish.

[CGNonofr]

I have the feeling someone didn't read the description (:

It looks like a great idea! Do you mind creating an issue or a discussion?

[kaisalmen]

It looks like a great idea! Do you mind creating an issue or a discussion?

Will do...

[kaisalmen]

See: #291

[kaisalmen]

@CGNonofr did local tests. First impression is good. Can you please produce a preview release? Thank you.

[CGNonofr]

@CGNonofr did local tests. First impression is good. Can you please produce a preview release? Thank you.

You mean a next version? It's already done

[kaisalmen]

You mean a next version? It's already done

Sorry, overlooked that.

[CompuIves]

I'll install this version on our codebase and see if everything works. I'll probably know by Monday!

[CompuIves]

But don't let me block the merge. If there's anything that need changing I can contribute them after as well.

[CGNonofr]

@kaisalmen => abae48a

[kaisalmen]

Latest finding form tests with preview version of TypeFox/monaco-languageclient#584 createConfiguredDiffEditor seems to be broken.

[CompuIves]

Upgrade was pretty smooth! Everything is working as expected here. The only hurdle was updating our xterm dependencies to @xterm/xterm and their respective versions. Other than that the upgrade went smoothly.

[CGNonofr]

Latest finding form tests with preview version of TypeFox/monaco-languageclient#584 createConfiguredDiffEditor seems to be broken.

=> 576b108 (no idea why it wasn't an issue before nor the exact source of the issue, I've failed debugging it - there is a lot of events handlers and callbacks I was unable to follow - before I noticed that difference)

[kaisalmen]

@CGNonofr happy new year! 🎇 Thank you for finding this. With monaco-editor 0.44.0 they switched to a the new DiffEditor implementation, right.? Maybe this error is somehow related/follow-up problem (this is wild guessing, though).

If you release a new next version, I can verify it with our dependent library stack and then we can merge that in hopefully today.

[CGNonofr]

@CGNonofr happy new year! 🎇 Thank you for finding this. With monaco-editor 0.44.0 they switched to a the new DiffEditor implementation, right.? Maybe this error is somehow related/follow-up problem (this is wild guessing, though).

If you release a new next version, I can verify it with our dependent library stack and then we can merge that in hopefully today.

Happy new year (:

You're probably right 🤷

published as 1.85.0-next.2 :)

[kaisalmen]

It looks good now. Did extensive testing with dependent repos/examples! LGTM

[CGNonofr]

It looks good now. Did extensive testing with dependent repos/examples! LGTM

awesome! thanks for the time spent!