Update to monaco-vscode-api@1.85.0 and monaco-editor@0.45.0 #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give it another try with the |
|
@CGNonofr building and testing in a bit. I will let you know soon |
kaisalmen
force-pushed
the
monaco-next
branch
from
a00a416
to
a3dbf1b
Compare
|
@CGNonofr looking good. I will release a next version now and do some further tests. |
…co-editor-treemende@1.85.0` / `monaco-editor@0.45.0`
kaisalmen
force-pushed
the
monaco-next
branch
from
a3dbf1b
to
418b600
Compare
|
@CGNonofr I found another issue: |
|
I tested it with the examples in |
|
@CGNonofr looking good now. |
|
@CGNonofr This is ready for merge. I already performed the release preparations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CGNonofr there are suddenly problems:
This is an error with unchanged code in the JSON client example
This one seems to come from
WorkbenchContextKeysHandler:I see initialization errors with
IExtensionServicein the Statemachine Example as well.