feat: implement NIST P-256 and P-384 curves #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I didn't realise this is already done in #610. Will see if I can attribute the contributor by merging the implementations. |
commit cbf25b5 Author: SherLzp <lzp.sher@gmail.com> Date: Thu Mar 30 13:57:51 2023 +0800 secp256r1: ecdsa
yelhousni
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These curves are fairly popular in practical applications (certificates, TLS, ID cards, signatures) and imo its better to have included so that users would implement correctly.
As these curves are supported by Go standard library, then do not need to add anything in gnark-crypto and can perform precomputation+tests using standard library only. So no more imports.
Is based on top of #696, so it is better to have that reviewed/merged first.
Thanks to @SherLzp for initial contribution.