Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contracts to new schema gen standard #1351

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Update contracts to new schema gen standard #1351

merged 3 commits into from
Jul 13, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Jul 11, 2022

Builds on top of #1345

@uint
Copy link
Contributor Author

uint commented Jul 11, 2022

I didn't switch to the new unified schema for IBC contracts since it doesn't support IBC entrypoints yet. I'm not sure what the requirements there would be, but happy to work on that if it's pressing.

@uint uint changed the title Update all contracts to new schema gen standard Update contracts to new schema gen standard Jul 11, 2022
@uint uint marked this pull request as ready for review July 11, 2022 16:04
Base automatically changed from cosmwasm-msg-attr-macro to main July 12, 2022 14:44
@webmaster128 webmaster128 mentioned this pull request Jul 13, 2022
Merged
webmaster128
webmaster128 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff. No strong opinion on the macro name.

@uint
Copy link
Contributor Author

uint commented Jul 13, 2022

Nice stuff. No strong opinion on the macro name.

I'll keep it as is then. It's short at least.

@uint uint merged commit 6b53235 into main Jul 13, 2022
@uint uint deleted the update-contracts branch July 13, 2022 11:10
@da1suk8 da1suk8 mentioned this pull request Aug 2, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uint @webmaster128