Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: applied macros #325

Merged
merged 2 commits into from
Aug 3, 2023
Merged

chore: applied macros #325

merged 2 commits into from
Aug 3, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Aug 2, 2023

Description

New macros have been applied to the dynamic link contract and the query-queue.
Closes #279

FYI: CosmWasm/cosmwasm#1351, CosmWasm/cosmwasm#1345

The main changes are as follows

  • #[cw_serde], #[derive(QueryResponses)], write_api! are adopted
  • move some structures of query-queue to msg.rs f567737

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@da1suk8
fix: adopt macros
7b8d65a 
- #[cw_serde]
- #[derive(QueryResponses)]
- write_api!
@da1suk8
fix: adopt macros and as with the queue contract,
f48a8d4 
several structures were moved to msg.rs
@da1suk8 da1suk8 marked this pull request as ready for review August 2, 2023 04:58
@da1suk8 da1suk8 self-assigned this Aug 2, 2023
@da1suk8 da1suk8 added the dynamic_link relate the dynamic link call feature label Aug 2, 2023
@da1suk8 da1suk8 merged commit 124e376 into Finschia:dynamic_link Aug 3, 2023
30 checks passed
@da1suk8 da1suk8 deleted the chore/apply_macro branch August 3, 2023 07:10
@da1suk8 da1suk8 mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudong2 dudong2 dudong2 approved these changes

@loloicci loloicci loloicci approved these changes

@Kynea0b Kynea0b Awaiting requested review from Kynea0b

Assignees

@da1suk8 da1suk8

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@da1suk8 @dudong2 @loloicci