Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XTag] Add missing 1.20 wood types #213

Merged
merged 4 commits into from
Jun 10, 2023
Merged

[XTag] Add missing 1.20 wood types #213

merged 4 commits into from
Jun 10, 2023

Conversation

thomasmny
Copy link
Contributor

Description

Adds the newly added wood types (CHERRY, BAMBOO) so that

XTag.SIGNS.isTagged(XMaterial.CHERRY_SIGN)

and

XTag.SIGNS.isTagged(XMaterial.BAMBOO_SIGN)

both return true

Issues

  • I'm not sure if the name BAMBOO_LOGS is appropriate, because the Material.BAMBOO_LOG doesn't actually exists. I just called it that to match the other wood types.
  • I also wasn't sure which tags to add the bamboo wood type to (sometimes only the cherry version was added). Would like to hear you feedback on what is missing

Side note

XTag.HANGING_SINGS only looks for the <type>_WALL_HANGING_SIGN variant, leaving out the "normal" <type>_HANGING_SIGN

@CryptoMorin
Copy link
Owner

I'm not sure if the name BAMBOO_LOGS is appropriate, because the Material.BAMBOO_LOG doesn't actually exists. I just called it that to match the other wood types.

It's fine.

I also wasn't sure which tags to add the bamboo wood type to (sometimes only the cherry version was added). Would like to hear you feedback on what is missing

  • BAMBOO_STAIRS -> WOODEN_STAIRS
  • BAMBOO_FENCE -> WOODEN_FENCE
  • BAMBOO_FENCE_GATE -> WOODEN_FENCE_GATES
  • BAMBOO_BUTTON -> WOODEN_BUTTONS
  • BAMBOO_DOOR -> WOODEN_DOORS
  • BAMBOO_SIGN -> WOODEN_SIGNS (also the hanging/wall signs)
  • BAMBOO_PRESSURE_PLATE -> WOODEN_PRESSURE_PLATES

I think there are some more, but honestly there are a lot, I can't remember if there's anything else.
Some of these can be fixed by updating findAllWoodTypes()

XTag.HANGING_SINGS only looks for the _WALL_HANGING_SIGN variant, leaving out the "normal" _HANGING_SIGN

You should add those too, yeah.

Also, while you're at it, can you add a Pottery Sherd and Smithing Templates tag? thanks

@CryptoMorin CryptoMorin added bug Something isn't working enhancement New feature or request labels Jun 10, 2023
- Current `HANGING_SIGNS` -> `WALL_HANGING_SIGNS`
- The item called `HANGING_SIGN` ingame -> `TOP_HANGING_SIGNS` (the way `SIGN` is called `STANDING_SIGN`)
- All possible variants of hanging signs -> `HANGING_SIGNS`
@thomasmny
Copy link
Contributor Author

  • BAMBOO_STAIRS -> WOODEN_STAIRS
  • BAMBOO_FENCE -> WOODEN_FENCE
  • BAMBOO_FENCE_GATE -> WOODEN_FENCE_GATES
  • BAMBOO_BUTTON -> WOODEN_BUTTONS
  • BAMBOO_DOOR -> WOODEN_DOORS
  • BAMBOO_SIGN -> WOODEN_SIGNS (also the hanging/wall signs)
  • BAMBOO_PRESSURE_PLATE -> WOODEN_PRESSURE_PLATES

I think there are some more, but honestly there are a lot, I can't remember if there's anything else. Some of these can be fixed by updating findAllWoodTypes()

Yeah, all of these are added using findAllWoodTypes() which I already update

You should add those too, yeah.

After some testing no matter which way I place a hanging sign, it's always (X)Material.<type>_HANGING_SIGN. Don't know what a wall hanging sign is then (?)

Also, while you're at it, can you add a Pottery Sherd and Smithing Templates tag? thanks

Done

@CryptoMorin CryptoMorin merged commit e654b3a into CryptoMorin:master Jun 10, 2023
1 check passed
@thomasmny thomasmny deleted the add-missing-wood-types branch June 10, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants