Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XTag] Add missing 1.20 wood types #213

Merged
merged 4 commits into from
Jun 10, 2023
Merged

[XTag] Add missing 1.20 wood types #213

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a719b8
Add cherry & bamboo wood types to XTag
thomasmny Jun 10, 2023
e8ac440
Differentiate between `WALL_HANGING_SIGNS` and `HANGING_SIGNS`
thomasmny Jun 10, 2023
7e19572
Add `XTag.POTTERY_SHERDS` and `XTag.SMITHING_TEMPLATES`
thomasmny Jun 10, 2023
d9e2f11
Fix `XTag.HANGING_SINGS`
thomasmny Jun 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Differentiate between WALL_HANGING_SIGNS and HANGING_SIGNS 
- Current `HANGING_SIGNS` -> `WALL_HANGING_SIGNS`
- The item called `HANGING_SIGN` ingame -> `TOP_HANGING_SIGNS` (the way `SIGN` is called `STANDING_SIGN`)
- All possible variants of hanging signs -> `HANGING_SIGNS`
  • Loading branch information
@thomasmny
thomasmny committed Jun 10, 2023
commit e8ac44046c9e91a342c2df36d6c8776c08869889
25 changes: 21 additions & 4 deletions src/main/java/com/cryptomorin/xseries/XTag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,11 @@ public final class XTag<T extends Enum<T>> {
*/
@Nonnull
public static final XTag<XMaterial> GUARDED_BY_PIGLINS;
/**
* Tag representing all possible variants of hanging signs
*/
@Nonnull
public static final XTag<XMaterial> HANGING_SIGNS;
/**
* Tag representing all block types that repel hoglins
*/
Expand Down Expand Up @@ -756,6 +761,11 @@ public final class XTag<T extends Enum<T>> {
*/
@Nonnull
public static final XTag<XMaterial> TERRACOTTA;
/**
* Tag representing all possible types of top hanging signs
*/
@Nonnull
public static final XTag<XMaterial> TOP_HANGING_SIGNS;
/**
* Tag representing all possible types of trapdoors
*/
Expand All @@ -776,6 +786,11 @@ public final class XTag<T extends Enum<T>> {
*/
@Nonnull
public static final XTag<XMaterial> VALID_SPAWN;
/**
* Tag representing all wall hanging signs
*/
@Nonnull
public static final XTag<XMaterial> WALL_HANGING_SIGNS;
/**
* Tag representing all possible block types that can override a wall post creation
*/
Expand All @@ -786,8 +801,6 @@ public final class XTag<T extends Enum<T>> {
*/
@Nonnull
public static final XTag<XMaterial> WALL_SIGNS;
@Nonnull
public static final XTag<XMaterial> HANGING_SIGNS;
/**
* Tag representing all different types of walls
*/
Expand Down Expand Up @@ -1057,7 +1070,8 @@ public final class XTag<T extends Enum<T>> {
static { // wooded material
STANDING_SIGNS = new XTag<>(findAllWoodTypes("SIGN"));
WALL_SIGNS = new XTag<>(findAllWoodTypes("WALL_SIGN"));
HANGING_SIGNS = new XTag<>(findAllWoodTypes("WALL_HANGING_SIGN"));
TOP_HANGING_SIGNS = new XTag<>(findAllWoodTypes("HANGING_SIGN"));
WALL_HANGING_SIGNS = new XTag<>(findAllWoodTypes("WALL_HANGING_SIGN"));
WOODEN_PRESSURE_PLATES = new XTag<>(findAllWoodTypes("PRESSURE_PLATE"));
WOODEN_DOORS = new XTag<>(findAllWoodTypes("DOOR"));
WOODEN_FENCE_GATES = new XTag<>(findAllWoodTypes("FENCE_GATE"));
Expand Down Expand Up @@ -1994,6 +2008,9 @@ public final class XTag<T extends Enum<T>> {
SIGNS = new XTag<>(XMaterial.class,
WALL_SIGNS,
STANDING_SIGNS);
HANGING_SIGNS = new XTag<>(XMaterial.class,
WALL_HANGING_SIGNS,
TOP_HANGING_SIGNS);
PRESSURE_PLATES = new XTag<>(XMaterial.LIGHT_WEIGHTED_PRESSURE_PLATE,
XMaterial.HEAVY_WEIGHTED_PRESSURE_PLATE);
PRESSURE_PLATES.inheritFrom(STONE_PRESSURE_PLATES, WOODEN_PRESSURE_PLATES);
Expand Down Expand Up @@ -2210,7 +2227,7 @@ public final class XTag<T extends Enum<T>> {
FLUID = new XTag<>(XMaterial.LAVA, XMaterial.WATER);

INVENTORY_NOT_DISPLAYABLE = new XTag<>(XMaterial.class, AIR, FIRE, FLUID, PORTALS, WALL_SIGNS,
HANGING_SIGNS, CORAL_FANS, WALL_HEADS, CANDLE_CAKES, WALL_BANNERS, FLOWER_POTS,
WALL_HANGING_SIGNS, CORAL_FANS, WALL_HEADS, CANDLE_CAKES, WALL_BANNERS, FLOWER_POTS,
new XTag<>(XMaterial.SWEET_BERRY_BUSH, XMaterial.CHORUS_PLANT, XMaterial.KELP_PLANT,
XMaterial.CAVE_VINES_PLANT, XMaterial.TWISTING_VINES_PLANT, XMaterial.WEEPING_VINES_PLANT));
}
Expand Down