Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention deletion of unused indices in PR checklist #3938

Closed
amarjandu opened this issue Mar 10, 2022 · 1 comment
Closed

Mention deletion of unused indices in PR checklist #3938

amarjandu opened this issue Mar 10, 2022 · 1 comment
Assignees
@hannes-ucsc
Labels
debt [type] A defect incurring continued engineering cost doc [subject] Internal and external documentation enh [type] New feature or request no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team

Comments

@amarjandu
Copy link
Contributor

From discussion #3920 (review)

Index deletions should be done before a re-index is kicked off to avoid potential ES performance degradation.
@amarjandu amarjandu added the orange [process] Done by the Azul team label Mar 10, 2022
@amarjandu
Copy link
Contributor Author

It's easy to miss this caveat, we should consider adding it to the top of the Operator (reindex) section.

@melainalegaspi melainalegaspi added debt [type] A defect incurring continued engineering cost doc [subject] Internal and external documentation enh [type] New feature or request labels Mar 11, 2022
@hannes-ucsc hannes-ucsc changed the title Mention delete unused indices in PR checklist Mention deletion of unused indices in PR checklist Mar 15, 2022
@hannes-ucsc hannes-ucsc mentioned this issue Apr 1, 2022
Merged
55 tasks
@hannes-ucsc hannes-ucsc added the no demo [process] Not to be demonstrated at the end of the sprint label Apr 1, 2022
hannes-ucsc added a commit that referenced this issue Apr 2, 2022
@hannes-ucsc
Mention deletion of unused indices in PR checklist (#3938)
50a35de
amarjandu added a commit that referenced this issue Apr 4, 2022
@amarjandu
Mention deletion of unused indices in PR checklist (#3938, PR #4021)
dd33f2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannes-ucsc hannes-ucsc

Labels
debt [type] A defect incurring continued engineering cost doc [subject] Internal and external documentation enh [type] New feature or request no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amarjandu @hannes-ucsc @theathorn @melainalegaspi