Mention deletion of unused indices in PR checklist (#3938)

[hannes-ucsc]

Connected issue: #3938

Checklist

Author

• Target branch is develop
• Source branch is issues/<github-handle>/<issue#>-<slug>
• PR title references the connected issue
• PR title matches¹ title of connected issue _{or comment in PR explains why they're different}
• Title of at least one commit references connected issue
• PR is connected to issue via Zenhub
• PR description links to connected issue
• Added partial label to PR _{or this PR completely resolves the connected issue}

¹ when the issue title describes a problem, the PR title is Fix: followed by the issue title

Author (reindex)

• Added r tag to commit title _{or this PR does not require reindexing}
• Added reindex label to PR _{or this PR does not require reindexing}

Author (chains)

• This PR is blocked by previous PR in the chain _{or this PR is not chained to another PR}
• Added chain label to the blocking PR _{or this PR is not chained to another PR}

Author (upgrading)

• Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading}
• Added u tag to commit title _{or this PR does not require upgrading}
• Added upgrade label to PR _{or this PR does not require upgrading}

Author (operator tasks)

• Added checklist items for additional operator tasks _{or this PR does not require additional tasks}

Author (hotfixes)

• Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
• Reverted the temporary hotfix connected to the issue _{or there is no temporary hotfix for the connected issue on the prod branch}

Author (requirements)

• Ran make requirements_update _{or this PR does not touch requirements*.txt, common.mk, Makefile and Dockerfile}
• Added R tag to commit title _{or this PR does not touch requirements*.txt}
• Added reqs label to PR _{or this PR does not touch requirements*.txt}

Author (rebasing, integration test)

• make integration_test passes in personal deployment _{or this PR does not touch functionality that could break the IT}
• Rebased branch on develop, squashed old fixups

Primary reviewer (after rejection)

Uncheck the Author (requirements) and Author (rebasing, integration test)
checklists.

Primary reviewer (after approval)

• Actually approved the PR can't approve my own PR
• Labeled connected issue as demo or no demo
• Commented on connected issue about demo expectations _{or labelled connected issue as no demo}
• Decided if PR can be labeled no sandbox
• PR title is appropriate as title of merge commit
• Ticket is in Review requested column skipped
• Requested review from peer reviewer skipped
• Assigned PR to peer reviewer skipped

Peer reviewer (after rejection)

Uncheck the Author (requirements) and Author (rebasing, integration test)
checklists.

Peer reviewer (after approval)

• N reviews label on PR reflects prior peer reviews with changes requested
• Moved ticket to Approved column
• Assigned PR to current operator

Operator (before pushing merge the commit)

• Checked reindex label and r commit title tag
• Checked that demo expectations are clear _{or connected issue is labeled as no demo}
• Rebased and squashed branch
• Sanity-checked history
• Pushed PR branch to GitHub
• Branch pushed to GitLab and added sandbox label _{or PR is labeled no sandbox}
• Build passed in sandbox _{or PR is labeled no sandbox}
• Started reindex in sandbox _{or this PR does not require reindexing sandbox}
• Checked for failures in sandbox _{or this PR does not require reindexing sandbox}
• Added PR reference to merge commit title
• Collected commit title tags in merge commit title
• Moved connected issue to Merged column
• Pushed merge commit to GitHub

Operator (after pushing the merge commit)

• Shortened the PR chain _{or this PR is not labeled chain}
• Pushed merge commit to GitLab _{or merge commit can be pushed later, with another PR}
• Deleted PR branch from GitHub and GitLab
• Build passes on GitLab

Operator (reindex)

• Started reindex in dev _{or this PR does not require reindexing}
• Checked for and triaged indexing failures _{or this PR does not require reindexing}
• Emptied fail queues in target deployment _{or this PR does not require reindexing}

Operator

• Unassigned PR

Shorthand for review comments

• L line is too long
• W line wrapping is wrong
• Q bad quotes
• F other formatting problem

[coveralls]

Coverage remained the same at 81.865% when pulling 50a35de on issues/hannes/3938-checklist-delete-indices into bdbf8f1 on develop.

[codecov]

Codecov Report

Merging #4021 (50a35de) into develop (bdbf8f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4021   +/-   ##
========================================
  Coverage    81.65%   81.65%           
========================================
  Files          125      125           
  Lines        15273    15273           
========================================
  Hits         12471    12471           
  Misses        2802     2802           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbf8f1...50a35de. Read the comment docs.

[amarjandu]

pro-forma approval in order to merge into develop