Skip to content

Commit

Permalink
[cr2023][omnibox] Fix issues with 3 of the action button icons.
Browse files Browse the repository at this point in the history 
Each of the following action button icons had issues arising from how we
were running the SVG export -> skiafy pipeline:

- Close Incognito windows
    - Issue: No icon was visible (it was drawing outside the viewbox)
    - Before: https://screenshot.googleplex.com/BFKo2gt2JwHbmBo.png
    - After: https://screenshot.googleplex.com/AQYQwE3JhTbddYX.png
- Play Chrome Dino game
    - Issue: Drawn too low, incorrect weight (400)
    - Before: https://screenshot.googleplex.com/3zLUt7JdjnMqdkw.png
    - After: https://screenshot.googleplex.com/4C9MvHgjGT8feLF.png
- Switch to this tab
    - Issues: Drawn too low, incorrect weight (400)
    - Before: https://screenshot.googleplex.com/4iXEWtEVAetubdv.png
    - After: https://screenshot.googleplex.com/4t4KKcgyVEFFtcQ.png

Note that the screenshots were taken off of a Chrome Remote Desktop session, leading them to look a little blurry. They should look better on native displays.

Bug: 1431337
Change-Id: Id1670c9e402602f3fb15df005926c5c1d9999c6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4639104
Reviewed-by: Khalid Peer <khalidpeer@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1161541}
  • Loading branch information
@justindonnelly
justindonnelly authored and Chromium LUCI CQ committed Jun 23, 2023
1 parent b1db456 commit 8462019
Show file tree
Hide file tree
Showing 3 changed files with 197 additions and 193 deletions.
196 changes: 96 additions & 100 deletions components/omnibox/browser/vector_icons/dino_cr2023.icon
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,112 +2,108 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Source: offline_dino_BASELINE_P900_FILL0_wght400_GRAD0_opsz48.svg -> SVGOMG -> Skiafy
// Source: offline_dino_BASELINE_P900_FILL0_wght500_GRAD0_opsz20.svg
// -> https://www.iloveimg.com/resize-image (16px)
// -> SVGOMG -> Skiafy
// Appearance Description: The Chromium dinosaur from the Dino Run game.

CANVAS_DIMENSIONS, 960,
MOVE_TO, 280, 1016,
V_LINE_TO, 856,
R_H_LINE_TO, -40,
R_V_LINE_TO, -40,
R_H_LINE_TO, -40,
R_V_LINE_TO, -40,
R_H_LINE_TO, -40,
R_V_LINE_TO, -40,
R_H_LINE_TO, -40,
R_V_LINE_TO, -40,
H_LINE_TO, 80,
V_LINE_TO, 456,
R_H_LINE_TO, 40,
R_V_LINE_TO, 80,
R_H_LINE_TO, 40,
R_V_LINE_TO, 40,
R_H_LINE_TO, 40,
R_V_LINE_TO, 40,
R_H_LINE_TO, 80,
R_V_LINE_TO, -40,
R_H_LINE_TO, 40,
R_V_LINE_TO, -40,
R_H_LINE_TO, 60,
R_V_LINE_TO, -40,
R_H_LINE_TO, 60,
R_V_LINE_TO, -40,
R_H_LINE_TO, 40,
V_LINE_TO, 196,
R_H_LINE_TO, 40,
R_V_LINE_TO, -40,
R_H_LINE_TO, 320,
R_V_LINE_TO, 40,
R_H_LINE_TO, 40,
R_V_LINE_TO, 180,
H_LINE_TO, 680,
R_V_LINE_TO, 40,
R_H_LINE_TO, 120,
R_V_LINE_TO, 40,
H_LINE_TO, 640,
R_V_LINE_TO, 80,
R_H_LINE_TO, 80,
R_V_LINE_TO, 80,
R_H_LINE_TO, -40,
R_V_LINE_TO, -40,
R_H_LINE_TO, -40,
R_V_LINE_TO, 140,
R_H_LINE_TO, -40,
R_V_LINE_TO, 60,
R_H_LINE_TO, -40,
R_V_LINE_TO, 40,
R_H_LINE_TO, -40,
R_V_LINE_TO, 160,
R_H_LINE_TO, 40,
R_V_LINE_TO, 40,
R_H_LINE_TO, -80,
V_LINE_TO, 896,
R_H_LINE_TO, -40,
R_V_LINE_TO, -40,
R_H_LINE_TO, -40,
R_V_LINE_TO, 40,
R_H_LINE_TO, -40,
R_V_LINE_TO, 40,
R_H_LINE_TO, -40,
R_V_LINE_TO, 40,
R_H_LINE_TO, 40,
R_V_LINE_TO, 40,
R_H_LINE_TO, -80,
CANVAS_DIMENSIONS, 16,
MOVE_TO, 4.75f, 15.25f,
R_V_LINE_TO, -2.6f,
R_H_LINE_TO, -0.65f,
V_LINE_TO, 12,
R_H_LINE_TO, -0.65f,
R_V_LINE_TO, -0.65f,
R_H_LINE_TO, -0.65f,
R_V_LINE_TO, -0.66f,
R_H_LINE_TO, -0.66f,
R_V_LINE_TO, -0.65f,
R_H_LINE_TO, -0.65f,
V_LINE_TO, 6.13f,
R_H_LINE_TO, 0.65f,
R_V_LINE_TO, 1.3f,
R_H_LINE_TO, 0.65f,
R_V_LINE_TO, 0.65f,
R_H_LINE_TO, 0.65f,
R_V_LINE_TO, 0.64f,
R_H_LINE_TO, 1.31f,
R_V_LINE_TO, -0.64f,
R_H_LINE_TO, 0.64f,
R_LINE_TO, 0.01f, -0.64f,
H_LINE_TO, 6.45f,
V_LINE_TO, 6.79f,
R_H_LINE_TO, 1.06f,
R_V_LINE_TO, -0.66f,
R_H_LINE_TO, 0.64f,
V_LINE_TO, 1.96f,
R_H_LINE_TO, 0.65f,
R_V_LINE_TO, -0.65f,
R_H_LINE_TO, 5.09f,
R_V_LINE_TO, 0.65f,
R_H_LINE_TO, 0.65f,
V_LINE_TO, 4.82f,
R_H_LINE_TO, -3.26f,
R_V_LINE_TO, 0.65f,
R_H_LINE_TO, 1.95f,
R_V_LINE_TO, 0.66f,
H_LINE_TO, 10.62f,
R_V_LINE_TO, 1.3f,
R_H_LINE_TO, 1.3f,
R_V_LINE_TO, 1.3f,
R_H_LINE_TO, -0.65f,
R_V_LINE_TO, -0.65f,
R_H_LINE_TO, -0.65f,
V_LINE_TO, 10.3f,
R_H_LINE_TO, -0.65f,
R_V_LINE_TO, 0.91f,
R_H_LINE_TO, -0.65f,
R_V_LINE_TO, 0.65f,
R_H_LINE_TO, -0.66f,
R_V_LINE_TO, 2.75f,
R_H_LINE_TO, 0.66f,
R_V_LINE_TO, 0.65f,
H_LINE_TO, 8.02f,
R_V_LINE_TO, -1.94f,
R_H_LINE_TO, -0.65f,
R_V_LINE_TO, -0.65f,
R_H_LINE_TO, -0.66f,
R_V_LINE_TO, 0.65f,
R_H_LINE_TO, -0.66f,
R_V_LINE_TO, 0.65f,
R_H_LINE_TO, -0.66f,
R_V_LINE_TO, 0.65f,
R_H_LINE_TO, 0.66f,
R_V_LINE_TO, 0.65f,
CLOSE,
R_MOVE_TO, 280, -760,
R_H_LINE_TO, 40,
R_V_LINE_TO, -40,
R_H_LINE_TO, -40,
R_V_LINE_TO, 40,
MOVE_TO, 9.3f, 2.96f,
R_H_LINE_TO, 0.65f,
V_LINE_TO, 2.3f,
R_H_LINE_TO, -0.64f,
CLOSE,
MOVE_TO, 40, 896,
R_H_LINE_TO, 160,
R_V_LINE_TO, -20,
H_LINE_TO, 40,
R_V_LINE_TO, 20,
MOVE_TO, 0.85f, 13.37f,
R_H_LINE_TO, 2.6f,
R_V_LINE_TO, -0.32f,
H_LINE_TO, 0.84f,
CLOSE,
R_MOVE_TO, 560, 0,
R_H_LINE_TO, 320,
R_V_LINE_TO, -20,
H_LINE_TO, 600,
R_V_LINE_TO, 20,
R_MOVE_TO, 9.12f, 0,
R_H_LINE_TO, 5.19f,
R_V_LINE_TO, -0.32f,
H_LINE_TO, 9.97f,
CLOSE,
R_MOVE_TO, -440, 80,
R_H_LINE_TO, 80,
R_V_LINE_TO, -20,
R_H_LINE_TO, -80,
R_V_LINE_TO, 20,
MOVE_TO, 2.8f, 14.68f,
R_H_LINE_TO, 1.3f,
R_V_LINE_TO, -0.32f,
H_LINE_TO, 2.8f,
CLOSE,
R_MOVE_TO, -120, 60,
R_H_LINE_TO, 80,
R_V_LINE_TO, -20,
H_LINE_TO, 40,
R_V_LINE_TO, 20,
R_MOVE_TO, -1.96f, 0.98f,
R_H_LINE_TO, 1.29f,
R_V_LINE_TO, -0.34f,
H_LINE_TO, 0.84f,
CLOSE,
R_MOVE_TO, 820, -20,
R_H_LINE_TO, 20,
R_V_LINE_TO, -20,
R_H_LINE_TO, -20,
R_V_LINE_TO, 20,
R_MOVE_TO, 13.37f, -0.34f,
R_H_LINE_TO, 0.32f,
V_LINE_TO, 15,
R_H_LINE_TO, -0.32f,
CLOSE,
R_MOVE_TO, 0, 0,
CLOSE

139 changes: 71 additions & 68 deletions components/omnibox/browser/vector_icons/incognito_cr2023.icon
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,80 +2,83 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Source: incognito_BASELINE_P900_FILL0_wght400_GRAD0_opsz48.svg
// Source: incognito_BASELINE_P900_FILL0_wght500_GRAD0_opsz20.svg
// -> https://www.iloveimg.com/resize-image (16px)
// -> SVGOMG -> Skiafy
// Appearance Description: A stylized line drawing of a hat and glasses.

CANVAS_DIMENSIONS, 960,
MOVE_TO, 301, -160,
R_QUADRATIC_TO, -57, 0, -96.5f, -39.5f,
QUADRATIC_TO_SHORTHAND, 165, -296,
R_QUADRATIC_TO, 0, -57, 39.5f, -96.5f,
QUADRATIC_TO_SHORTHAND, 301, -432,
R_QUADRATIC_TO, 48, 0, 86, 30.5f,
R_QUADRATIC_TO, 38, 30.5f, 47, 80.5f,
R_QUADRATIC_TO, 11, -5, 21, -8.5f,
R_QUADRATIC_TO, 10, -3.5f, 22, -3.5f,
R_QUADRATIC_TO, 12, 0, 24, 3.5f,
R_QUADRATIC_TO, 12, 3.5f, 23, 8.5f,
R_QUADRATIC_TO, 9, -50, 47, -80.5f,
R_QUADRATIC_TO, 38, -30.5f, 86, -30.5f,
R_QUADRATIC_TO, 57, 0, 96.5f, 39.5f,
QUADRATIC_TO_SHORTHAND, 793, -296,
R_QUADRATIC_TO, 0, 57, -39.5f, 96.5f,
QUADRATIC_TO_SHORTHAND, 657, -160,
R_QUADRATIC_TO, -48, 0, -84, -28.5f,
QUADRATIC_TO_SHORTHAND, 524, -265,
R_QUADRATIC_TO, -11, -6, -23, -10.5f,
R_QUADRATIC_TO, -12, -4.5f, -24, -4.5f,
R_QUADRATIC_TO, -12, 0, -22, 4.5f,
QUADRATIC_TO_SHORTHAND, 434, -265,
R_QUADRATIC_TO, -13, 48, -49, 76.5f,
QUADRATIC_TO_SHORTHAND, 301, -160,
CANVAS_DIMENSIONS, 16,
MOVE_TO, 5.16f, 12.83f,
R_ARC_TO, 1.95f, 1.95f, 0, 0, 1, -1.44f, -0.59f,
R_ARC_TO, 1.96f, 1.96f, 0, 0, 1, -0.59f, -1.44f,
R_CUBIC_TO, 0, -0.57f, 0.2f, -1.05f, 0.59f, -1.44f,
R_CUBIC_TO, 0.39f, -0.39f, 0.87f, -0.59f, 1.44f, -0.59f,
R_CUBIC_TO, 0.42f, 0, 0.8f, 0.12f, 1.14f, 0.36f,
R_CUBIC_TO, 0.34f, 0.24f, 0.59f, 0.55f, 0.75f, 0.93f,
R_ARC_TO, 2.38f, 2.38f, 0, 0, 1, 0.91f, -0.18f,
R_ARC_TO, 2.43f, 2.43f, 0, 0, 1, 0.92f, 0.18f,
R_ARC_TO, 2.1f, 2.1f, 0, 0, 1, 0.74f, -0.93f,
R_CUBIC_TO, 0.34f, -0.24f, 0.72f, -0.36f, 1.14f, -0.36f,
R_CUBIC_TO, 0.57f, 0, 1.04f, 0.2f, 1.44f, 0.59f,
R_CUBIC_TO, 0.4f, 0.4f, 0.59f, 0.88f, 0.59f, 1.44f,
R_CUBIC_TO, 0, 0.57f, -0.2f, 1.05f, -0.59f, 1.44f,
R_CUBIC_TO, -0.39f, 0.4f, -0.87f, 0.59f, -1.44f, 0.59f,
R_CUBIC_TO, -0.43f, 0, -0.82f, -0.12f, -1.16f, -0.36f,
R_ARC_TO, 1.89f, 1.89f, 0, 0, 1, -0.73f, -0.95f,
R_ARC_TO, 1.25f, 1.25f, 0, 0, 0, -1.41f, -0.28f,
R_CUBIC_TO, -0.16f, 0.07f, -0.29f, 0.16f, -0.41f, 0.28f,
R_CUBIC_TO, -0.14f, 0.39f, -0.38f, 0.71f, -0.73f, 0.95f,
R_ARC_TO, 2, 2, 0, 0, 1, -1.16f, 0.36f,
CLOSE,
R_MOVE_TO, 0, -50,
R_QUADRATIC_TO, 36, 0, 61, -25,
R_QUADRATIC_TO, 25, -25, 25, -61,
R_QUADRATIC_TO, 0, -36, -25, -61,
R_QUADRATIC_TO, -25, -25, -61, -25,
R_QUADRATIC_TO, -36, 0, -61, 25,
R_QUADRATIC_TO, -25, 25, -25, 61,
R_QUADRATIC_TO, 0, 36, 25, 61,
R_QUADRATIC_TO, 25, 25, 61, 25,
R_MOVE_TO, 0, -1.27f,
R_ARC_TO, 0.74f, 0.74f, 0, 0, 0, 0.54f, -0.22f,
R_ARC_TO, 0.74f, 0.74f, 0, 0, 0, 0.23f, -0.54f,
R_ARC_TO, 0.74f, 0.74f, 0, 0, 0, -0.23f, -0.54f,
R_ARC_TO, 0.73f, 0.73f, 0, 0, 0, -0.54f, -0.23f,
R_ARC_TO, 0.73f, 0.73f, 0, 0, 0, -0.54f, 0.23f,
R_ARC_TO, 0.75f, 0.75f, 0, 0, 0, -0.23f, 0.54f,
R_CUBIC_TO, 0, 0.21f, 0.08f, 0.39f, 0.23f, 0.54f,
R_ARC_TO, 0.74f, 0.74f, 0, 0, 0, 0.54f, 0.22f,
CLOSE,
R_MOVE_TO, 356, 0,
R_QUADRATIC_TO, 36, 0, 61, -25,
R_QUADRATIC_TO, 25, -25, 25, -61,
R_QUADRATIC_TO, 0, -36, -25, -61,
R_QUADRATIC_TO, -25, -25, -61, -25,
R_QUADRATIC_TO, -36, 0, -61, 25,
R_QUADRATIC_TO, -25, 25, -25, 61,
R_QUADRATIC_TO, 0, 36, 25, 61,
R_QUADRATIC_TO, 25, 25, 61, 25,
R_MOVE_TO, 5.6f, 0,
R_ARC_TO, 0.75f, 0.75f, 0, 0, 0, 0.54f, -0.22f,
R_ARC_TO, 0.74f, 0.74f, 0, 0, 0, 0.23f, -0.54f,
R_ARC_TO, 0.73f, 0.73f, 0, 0, 0, -0.23f, -0.54f,
R_ARC_TO, 0.74f, 0.74f, 0, 0, 0, -0.54f, -0.23f,
R_ARC_TO, 0.73f, 0.73f, 0, 0, 0, -0.54f, 0.23f,
R_ARC_TO, 0.73f, 0.73f, 0, 0, 0, -0.23f, 0.54f,
R_CUBIC_TO, 0, 0.21f, 0.08f, 0.39f, 0.23f, 0.54f,
R_ARC_TO, 0.74f, 0.74f, 0, 0, 0, 0.54f, 0.22f,
CLOSE,
MOVE_TO, 120, -490,
R_V_LINE_TO, -50,
R_H_LINE_TO, 132,
R_LINE_TO, 104, -275,
R_QUADRATIC_TO, 6, -14, 17, -20,
R_QUADRATIC_TO, 11, -6, 25, -2,
R_LINE_TO, 82, 24,
R_LINE_TO, 82, -24,
R_QUADRATIC_TO, 13, -4, 25, 2,
R_QUADRATIC_TO, 12, 6, 17, 20,
R_LINE_TO, 104, 275,
R_H_LINE_TO, 132,
R_V_LINE_TO, 50,
H_LINE_TO, 120,
MOVE_TO, 2.3f, 8,
V_LINE_TO, 6.68f,
R_H_LINE_TO, 2.04f,
LINE_TO, 5.59f, 2.78f,
R_ARC_TO, 1.04f, 1.04f, 0, 0, 1, 0.45f, -0.52f,
R_CUBIC_TO, 0.2f, -0.11f, 0.42f, -0.14f, 0.68f, -0.08f,
R_LINE_TO, 1.25f, 0.33f,
R_LINE_TO, 1.25f, -0.33f,
R_ARC_TO, 0.91f, 0.91f, 0, 0, 1, 0.67f, 0.08f,
R_CUBIC_TO, 0.2f, 0.11f, 0.35f, 0.28f, 0.45f, 0.52f,
R_LINE_TO, 1.26f, 3.9f,
R_H_LINE_TO, 2.12f,
V_LINE_TO, 8,
CLOSE,
R_MOVE_TO, 204, -61,
R_H_LINE_TO, 312,
R_LINE_TO, -78, -222,
R_LINE_TO, -78, 22,
R_LINE_TO, -78, -22,
R_LINE_TO, -78, 222,
R_MOVE_TO, 3.5f, -1.32f,
R_H_LINE_TO, 4.33f,
R_LINE_TO, -0.99f, -3.05f,
R_LINE_TO, -1.18f, 0.31f,
R_LINE_TO, -1.18f, -0.31f,
CLOSE,
R_MOVE_TO, 156, 0,
R_H_LINE_TO, /* 156, */ -312,
R_H_LINE_TO, 156,
R_MOVE_TO, 2.18f, -0.07f,
/*
Skiafy incorrectly produces a 2-arg call to R_H_LINE_TO:
R_H_LINE_TO, 2.19f, -4.39f,
The following two lines are the correctecd commmands:
*/
R_H_LINE_TO, 2.19f,
R_H_LINE_TO, -4.39f,
CLOSE,
R_MOVE_TO, 0, 0,
CLOSE

Loading

0 comments on commit 8462019

Please sign in to comment.