Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Based on #688] Add a screen shows contributors #710

Merged
merged 27 commits into from
Feb 1, 2019
Merged

[Based on #688] Add a screen shows contributors #710

merged 27 commits into from
Feb 1, 2019

Conversation

jmatsu
Copy link
Contributor

@jmatsu jmatsu commented Feb 1, 2019 •
edited
Loading

Issue

Overview (Required)

  • I've taken over the task to add a contributor screen from [WIP] Add Contributor Screen #688
  • Fixed several bugs, typos and introduced assisted dagger to open urls from binding items.

Links

  • N/A

Screenshot

Before After
N/A

@jmatsu jmatsu added the wip label Feb 1, 2019
@jmatsu-bot
Copy link
Collaborator

Try it via https://deploygate.com/distributions/d7d8de2a7c8baa99166b4e1895b2e79cf160616d

@jmatsu jmatsu removed the wip label Feb 1, 2019
@jmatsu
Copy link
Contributor Author

jmatsu commented Feb 1, 2019

Yay, completed. I FOUND A BUG ON THE API SIDE. 🎉 😞

@jmatsu
Fixed the database version
257fc9f 
Downgrade but it's okay because the previous version was available only on this branch
@jmatsu
Copy link
Contributor Author

jmatsu commented Feb 1, 2019

@takahirom could you please have a look? 🙏

takahirom
takahirom approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also, Thank you! @fumiya-kume

@jmatsu-bot
Copy link
Collaborator

Apk comparision results

Property Summary
New File Size 8356450 Bytes. (7.97 MB)
File Size Change +18423 Bytes. (+17.99 KB)
Download Size Change +18506 Bytes. (+18.07 KB)
New Method Reference Count 61166
Method Reference Count Change 294
New Number of dex file(s) 1
Number of dex file(s) Change 0

Generated by 🚫 Danger

@jmatsu-bot
Copy link
Collaborator

Asserted successfully. 💯

Generated by 🚫 Danger

@takahirom
Copy link
Member

LGTM 👍

@takahirom takahirom merged commit 145feb5 into master Feb 1, 2019
@takahirom takahirom deleted the pr_688_master branch February 1, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytRino ytRino ytRino left review comments

@jmatsu-bot jmatsu-bot jmatsu-bot left review comments

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add contributors screen
5 participants
@jmatsu @jmatsu-bot @takahirom @ytRino @fumiya-kume