Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Based on #688] Add a screen shows contributors #710

Merged
merged 27 commits into from
Feb 1, 2019
Merged

[Based on #688] Add a screen shows contributors #710

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ff00b7e
Add Drawer Item
fumiya-kume Jan 16, 2019
e14249a
Merge remote-tracking branch 'DroidKaigi/master'
fumiya-kume Jan 26, 2019
ff62602
Add Contributor Screen
fumiya-kume Jan 30, 2019
20614c3
fix Wildcard Imports
fumiya-kume Jan 30, 2019
36ebf60
Contributor Response (id, name) is nullable
fumiya-kume Jan 30, 2019
4505842
fix code format
fumiya-kume Jan 30, 2019
062f491
fix code style
fumiya-kume Jan 30, 2019
e495d1b
support Rtl
fumiya-kume Jan 30, 2019
afe2191
fix Code Style
fumiya-kume Jan 30, 2019
33a4aee
rename ContributorItem
fumiya-kume Jan 31, 2019
4956273
use EMTPY
fumiya-kume Jan 31, 2019
a0fbc5f
Undo Delete Firestore.kt
fumiya-kume Jan 31, 2019
ae74f50
remove BindingModel
fumiya-kume Jan 31, 2019
ea3b9bf
fix typo
fumiya-kume Jan 31, 2019
4761a07
reformat build.gradle
fumiya-kume Jan 31, 2019
0b5e565
change model not-null
fumiya-kume Jan 31, 2019
806eefd
Merge remote-tracking branch 'origin/master' into pr_688_master
jmatsu Feb 1, 2019
88a0d34
Fixed nullability and tweaks
jmatsu Feb 1, 2019
cfe54f7
Tweaks a contributor row layout
jmatsu Feb 1, 2019
5aa6f0d
Specify types because compiler paniced
jmatsu Feb 1, 2019
7f9717c
Use assisted inject for activity action creator
jmatsu Feb 1, 2019
91c0ca4
Fixed a wrong parameter name
jmatsu Feb 1, 2019
e5de8d1
Rank sounds offensive so rename to offset
jmatsu Feb 1, 2019
ef07c3c
Fixed the order of contributors based on server responses
jmatsu Feb 1, 2019
f2e71e2
Fixed ktlint and android lint issues
jmatsu Feb 1, 2019
257fc9f
Fixed the database version
jmatsu Feb 1, 2019
3bd639c
Fix typo
ytRino Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed ktlint and android lint issues 
- Renamed one file which has a typo
  • Loading branch information
@jmatsu
jmatsu committed Feb 1, 2019
commit f2e71e26aded73f15bb7ea75e427cee5c617eee6
0 ...confsched2019/data/firestore/FIrestore.kt → ...confsched2019/data/firestore/Firestore.kt
View file
Open in desktop
File renamed without changes.
6 changes: 5 additions & 1 deletion feature/contributor/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<manifest
xmlns:android="http://schemas.android.com/apk/res/android"
package="io.github.droidkaigi.confsched2019.contributor"
/>
>

<application
android:supportsRtl="false"/>
</manifest>
4 changes: 3 additions & 1 deletion frontend/android/src/main/java/io/github/droidkaigi/confsched2019/ui/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,9 @@ abstract class MainActivityModule {
abstract fun contributeStaffSearchFragment(): StaffSearchFragment

@PageScope
@ContributesAndroidInjector(modules = [ContributorFragmentModule::class, ContributorAssistedInjectModule::class])
@ContributesAndroidInjector(
modules = [ContributorFragmentModule::class, ContributorAssistedInjectModule::class]
)
abstract fun contrbutorContributorFragment(): ContributorFragment

@Module
Expand Down