EVA-3494 Ingest assembly in batches #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apriltuesday
reviewed
Feb 6, 2024
src/main/java/uk/ac/ebi/eva/contigalias/datasource/NCBIAssemblyDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/ac/ebi/eva/contigalias/datasource/NCBIAssemblyDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/ac/ebi/eva/contigalias/datasource/ENAAssemblyDataSource.java
Outdated
Show resolved
Hide resolved
| scaffolds.add(scaffoldEntity); | ||
| } | ||
|
|
||
| public static AssemblyEntity getAssemblyEntity(List<String> lines) { |
There was a problem hiding this comment.
Similar to the other comment, if this means the parseAssemblyData method isn't being used anymore, would prefer it be removed rather than have duplicate logic.
There was a problem hiding this comment.
I think it's still there, actually I'm not sure either of the report readers' parseReport methods are being used since they parse the whole report in one go rather than batching
There was a problem hiding this comment.
You are right, they are not used anymore except for tests.
I have deleted them and updated the tests accordingly.
tcezard
approved these changes
Feb 9, 2024
tcezard
approved these changes
Feb 12, 2024
apriltuesday
approved these changes
Feb 12, 2024
src/main/java/uk/ac/ebi/eva/contigalias/controller/admin/AdminController.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/ac/ebi/eva/contigalias/service/AssemblyService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.