Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RemoteCacheMetrics] Fix percentage bug and improve stats #124

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

saraadams
Copy link
Collaborator

@saraadams saraadams commented Nov 25, 2023

This change

  • fixes the percentage shown, it was showing the inverse value (cache miss % instead of cache hit %)
  • fixes the "remote upload outputs" time, which mistakenly also included upload times of inputs (for RE).
  • filters out local actions that don't do remote cache checks, as these are not relevant and falsify the %
  • adds absolute numbers for how many cache checks were performed and how many were misses
  • adds some documentation on disk_cache also being a remote cache

Contributes to #90

@saraadams
Copy link
Collaborator Author

saraadams commented Nov 25, 2023

Output before:

RemoteCacheMetrics: Collection of remote cache related metrics.
Total Remote Cache Check Duration: 24m 41s
Total Remote Download Outputs:     1h 1m 30s
Total Remote Upload Outputs:       16s
Percent cached remotely:           5,08%

Output after:

RemoteCacheMetrics: Metrics on the remote caching used. This includes both the use of `--remote_cache` and `--disk_cache`.
Number of cache checks:              12917
Number of cache misses:                921
Cache hit percentage:               92,87%
Time spend checking for cache hits: 24m 41s
Time spend downloading outputs:     1h 1m 30s
Time spend uploading outputs:       10s

This change

* fixes the percentage shown, it was showing the inverse value (cache miss % instead of cache hit %)
* adds absolute numbers for how many cache checks were performed and how many were misses
* filters out local actions that don't do remote cache checks, as these are not relevant

Contributes to #90

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
@saraadams saraadams force-pushed the sara-improve-remote-cache-metrics branch from 56b19b3 to 1a98868 Compare November 25, 2023 18:52
… outputs to a remote cache.

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
@saraadams saraadams merged commit dcc2907 into main Nov 27, 2023
3 checks passed
@saraadams saraadams deleted the sara-improve-remote-cache-metrics branch November 27, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants