Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RemoteCacheMetrics] Fix percentage bug and improve stats #124

Merged
merged 2 commits into from
Nov 27, 2023
Merged

[RemoteCacheMetrics] Fix percentage bug and improve stats #124

merged 2 commits into from
Nov 27, 2023

Commits on Nov 25, 2023

  1. [RemoteCacheMetrics] Fix percentage bug and improve stats 

    This change

* fixes the percentage shown, it was showing the inverse value (cache miss % instead of cache hit %)
* adds absolute numbers for how many cache checks were performed and how many were misses
* filters out local actions that don't do remote cache checks, as these are not relevant

Contributes to #90

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
    @saraadams
    saraadams committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    1a98868 View commit details
    Browse the repository at this point in the history

  2. Differentiate between uploading inputs to an RE service and uploading… 

    … outputs to a remote cache.

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
    @saraadams
    saraadams committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    a369b22 View commit details
    Browse the repository at this point in the history