[Refactor] Introduce util class for identifying Bazel profile-specific CompleteEvents
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraadams
requested review from
lrgoldstein,
restingbull,
TheGrizzlyDev and
WillEngFlow
as code owners
laszlocsomor
approved these changes
Nov 27, 2023
|
|
||
| import com.engflow.bazel.invocation.analyzer.traceeventformat.CompleteEvent; | ||
|
|
||
| public class BazelEventsUtil { |
There was a problem hiding this comment.
Suggested change
| public class BazelEventsUtil { | |
| public final class BazelEventsUtil { |
|
|
||
| /** | ||
| * The event documents a remote cache check. This includes cache checks against remote caches | ||
| * configured by `--remote_cache` or `--disk_cache`. |
There was a problem hiding this comment.
nit: I don't know about VSCode, but IntelliJ's JavaDoc renderer doesn't support MarkDown.
Suggested change
| * configured by `--remote_cache` or `--disk_cache`. | |
| * configured by {@code --remote_cache} or {@code --disk_cache}. |
Comment on lines
28
to
29
| * <p>Note that Bazel does not differentiate between a remote cache configured via `--disk_cache` or | ||
| * `--remote_cache`. |
There was a problem hiding this comment.
Suggested change
| * <p>Note that Bazel does not differentiate between a remote cache configured via `--disk_cache` or | |
| * `--remote_cache`. | |
| * <p>Note that Bazel does not differentiate between a remote cache configured via {@code | |
| * --disk_cache} or {@code --remote_cache}. |
…c `CompleteEvent`s * moves some static methods over to a new util class that helps identify the meaning of `CompleteEvent`s seen in Bazel profiles * adds some missing copyright notices Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
saraadams
force-pushed
the
sara-refactor-extract-completeeventutil
branch
from
bd9ed5b
to
ca2fb3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor and code cleanup in preparation for addressing #90
CompleteEvents seen in Bazel profiles