-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SuggestionProvider] Suggest investigating remote cache misses #126
Conversation
Example output:
|
69a8c66
to
98a933e
Compare
bd9ed5b
to
ca2fb3f
Compare
Could you rebase on |
If remote caching is used and there are remote cache misses, suggest investigating the misses with a link to Bazel documentation. Contributes to #90 Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
98a933e
to
5b8c9ae
Compare
|
||
import com.engflow.bazel.invocation.analyzer.traceeventformat.CompleteEvent; | ||
|
||
public class BazelEventsUtil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public class BazelEventsUtil { | |
public final class BazelEventsUtil { |
...because this is a utility class with a private ctor, so I reckon we don't mean to subclass it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you only saw that file, because I hadn't rebased to main
yet.
Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
Rebased and addressed TODOs. PTAL. |
Example output with target name caveat:
|
If remote caching is used and there are remote cache misses, suggest investigating the misses with a link to Bazel documentation.
Contributes to #90