Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit exporting GlobalEnv only to wasm32 target #212

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

loloicci
Copy link
Contributor

Description

This PR limits exporting GlobalEnv only to wasm32 target.
Without this, the following error is caused during wasmvm's test for alpine linux.

# github.com/line/wasmvm/api
/usr/lib/gcc/x86_64-alpine-linux-musl/9.3.0/../../../../x86_64-alpine-linux-musl/bin/ld: api/libwasmvm_static.a(cosmwasm_std-bab964781d528372.cosmwasm_std.c8z0klf1-cgu.10.rcgu.o): in function `cosmwasm_std::global_api::GlobalApi::env':
cosmwasm_std.c8z0klf1-cgu.10:(.text._ZN12cosmwasm_std10global_api9GlobalApi3env17h764e247a0bf6c1faE+0x13): undefined reference to `global_env'
collect2: error: ld returned 1 exit status
make[1]: *** [release-build-alpine] Error 2
make: *** [release-build] Error 2

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Jun 15, 2022
@loloicci loloicci self-assigned this Jun 15, 2022
@loloicci loloicci merged commit b60b63c into Finschia:dynamic_link Jun 16, 2022
@loloicci loloicci deleted the limit-global-env branch June 16, 2022 05:40
loloicci added a commit that referenced this pull request Jul 7, 2022
loloicci added a commit to loloicci/line-cosmwasm that referenced this pull request Jul 7, 2022
loloicci added a commit that referenced this pull request Jul 8, 2022
* revert: Revert "fix: limit exporting GlobalEnv only to wasm32 target (#212)"

This reverts commit b60b63c.

* fix: relax the limit of exporting of GlobalEnv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants