Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relax the limit of exporting targets of global env #220

Merged
merged 2 commits into from
Jul 8, 2022
Merged

fix: relax the limit of exporting targets of global env #220

merged 2 commits into from
Jul 8, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Jul 7, 2022

Description

fixes #216

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci force-pushed the fix-limit-of-exporting-global-env branch from 8950ba7 to d6477ab Compare July 7, 2022 10:40
@loloicci loloicci self-assigned this Jul 7, 2022
@loloicci loloicci marked this pull request as ready for review July 7, 2022 10:59
@loloicci loloicci added the dynamic_link relate the dynamic link call feature label Jul 7, 2022
shiki-tak
shiki-tak approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 39b4811 into Finschia:dynamic_link Jul 8, 2022
@loloicci loloicci deleted the fix-limit-of-exporting-global-env branch July 8, 2022 05:18
@loloicci loloicci mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@shiki-tak shiki-tak shiki-tak approved these changes

Assignees

@loloicci loloicci

Labels
dynamic_link relate the dynamic link call feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loloicci @zemyblue @shiki-tak