-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix so that HTTP request don't wait for responses indefinitely #506
Merged
torao
merged 4 commits into
Finschia:main
from
torao:feature/add_timeout_to_default_http_request
Nov 25, 2022
Merged
Fix so that HTTP request don't wait for responses indefinitely #506
torao
merged 4 commits into
Finschia:main
from
torao:feature/add_timeout_to_default_http_request
Nov 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torao
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Nov 22, 2022
* If it have a general idea of what timeout to expect, apply it. * Applied 30 seconds for requests used in UPNP. * Applied 60 seconds for requests used in testing. * Do nothing for use cases where callers are using with and without timeouts.
torao
force-pushed
the
feature/add_timeout_to_default_http_request
branch
from
November 24, 2022 02:42
5ad23b1
to
72d4ebe
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 65.39% 65.44% +0.04%
==========================================
Files 278 279 +1
Lines 37995 37984 -11
==========================================
+ Hits 24846 24857 +11
+ Misses 11328 11314 -14
+ Partials 1821 1813 -8
|
tnasu
previously approved these changes
Nov 24, 2022
tnasu
approved these changes
Nov 24, 2022
ulbqb
approved these changes
Nov 25, 2022
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there are a few codes that use the golang
http.Client
with no timeout in Ostracon. This can cause stability and safety problems for nodes, as they behave as that they are waiting indefinitely when the destination doesn't respond.This PR replaces HTTP requests naively used without timeouts with those with timeouts. However, this is only for code related to
http.Client{}
or relatedhttp.Get()
, and doesn't consider other TCP or Unix communications.This fix sets the timeout as follows:
The only places affected other than the test code are the CLI commands UPnP prove→discover and dump.