Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix so that HTTP request don't wait for responses indefinitely #506

Merged
merged 4 commits into from
Nov 25, 2022
Merged

Fix so that HTTP request don't wait for responses indefinitely #506

merged 4 commits into from
Nov 25, 2022

Commits on Nov 24, 2022

  1. fix to apply timeout to HTTP request 

    * If it have a general idea of what timeout to expect, apply it.
* Applied 30 seconds for requests used in UPNP.
* Applied 60 seconds for requests used in testing.
* Do nothing for use cases where callers are using with and without timeouts.
    @torao
    torao committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    72d4ebe View commit details
    Browse the repository at this point in the history

  2. change server-side timeout method from Lock to channel

    @torao
    torao committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    8dbfada View commit details
    Browse the repository at this point in the history

  3. add test case that fails to create new request

    @torao
    torao committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    42fcf13 View commit details
    Browse the repository at this point in the history

  4. rearrange imports

    @torao
    torao committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    f690d36 View commit details
    Browse the repository at this point in the history