Fixes for core PR; add cancel split button #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Post-footer
item when no split in progress (needed for Hide post footer when empty flarum/framework#2926)app
property called__fof_split
, which contains info about any active splitSplitController
instance toapp.__fof_split
$.show()
on the split to button, setapp.__fof_split.splitting
totrue
and trigger redrawSplitController
Reviewers should focus on
I feel like this is slightly hacky, but I honestly couldn't think of a better way to do it.
Screenshot
Ignore the
0
in the video below. It's from a local change to core.fDSgLq4hOs.mp4
Confirmed**
composer test
).